Fix wrong page count returned in FPDF_GetPageCount() during loading dynamic XFA files

Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files

In FPDF_GetPageCount(), 'document' is converted to a non-XFA
document pointer (CPDF_Document*). So it only returns non-XFA
or static XFA page count. If XFA files include dynamic XFA fields
on some pages, the returned value doesn't reflect these pages.

BUG=pdfium:278
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a2167107bbcef6a3e3687d49a5b1e62503391316

[jun_fang, 2015-11-13 16:33:36]

Description was changed from

==========
Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files

BUG=pdfium:278
==========

to

==========
Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files

In FPDF_GetPageCount(), 'document' is converted to a non-XFA document pointer
(CPDF_Document*). So it only returns non-XFA or static XFA page count. If XFA
files include dynamic XFA fields on some pages, the returned value doesn't
reflect these pages.

BUG=pdfium:278
==========

[jun_fang, 2015-11-13 16:33:36]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-11-13 16:34:03]

Description was changed from

==========
Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files

In FPDF_GetPageCount(), 'document' is converted to a non-XFA document pointer
(CPDF_Document*). So it only returns non-XFA or static XFA page count. If XFA
files include dynamic XFA fields on some pages, the returned value doesn't
reflect these pages.

BUG=pdfium:278
==========

to

==========
Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files

In FPDF_GetPageCount(), 'document' is converted to a non-XFA 
document pointer (CPDF_Document*). So it only returns non-XFA
or static XFA page count. If XFA files include dynamic XFA fields
on some pages, the returned value doesn't reflect these pages.

BUG=pdfium:278
==========

[jun_fang, 2015-11-13 16:39:13]

On 2015/11/13 16:34:03, jun_fang wrote:
> Description was changed from
> 
> ==========
> Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files
> 
> In FPDF_GetPageCount(), 'document' is converted to a non-XFA document pointer
> (CPDF_Document*). So it only returns non-XFA or static XFA page count. If XFA
> files include dynamic XFA fields on some pages, the returned value doesn't
> reflect these pages.
> 
> BUG=pdfium:278
> ==========
> 
> to
> 
> ==========
> Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA files
> 
> In FPDF_GetPageCount(), 'document' is converted to a non-XFA 
> document pointer (CPDF_Document*). So it only returns non-XFA
> or static XFA page count. If XFA files include dynamic XFA fields
> on some pages, the returned value doesn't reflect these pages.
> 
> BUG=pdfium:278
> ==========

Will provide a test case for this CL.

[Tom Sepez, 2015-11-13 16:46:52]

Looks good, let me know when you've added the test to the CL.

[Tom Sepez, 2015-11-24 17:14:19]

Lets land this and deal with the tests later. LGTM.

[Tom Sepez, 2015-11-24 17:22:06]

Committed patchset #1 (id:1) manually as
a2167107bbcef6a3e3687d49a5b1e62503391316 (presubmit successful).

[Tom Sepez, 2015-11-24 17:22:54]

On 2015/11/24 17:22:06, Tom Sepez wrote:
> Committed patchset #1 (id:1) manually as
> a2167107bbcef6a3e3687d49a5b1e62503391316 (presubmit successful).

(I landed this on your behalf since it is going to conflict with some work I'm
doing to reduce xfa/master textual diffs.)