Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1442643009: Rename original constructor to new target (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename original constructor to new target BUG= Committed: https://crrev.com/07c1d181e7d8ec838ea5f97e0514ce2a426b1f88 Cr-Commit-Position: refs/heads/master@{#32023}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -209 lines) Patch
M src/arm/builtins-arm.cc View 1 2 13 chunks +16 lines, -16 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 16 chunks +21 lines, -22 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 9 chunks +15 lines, -15 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 15 chunks +16 lines, -16 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 13 chunks +16 lines, -16 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 13 chunks +16 lines, -16 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +15 lines, -15 lines 0 comments Download
M src/runtime/runtime-array.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 15 chunks +16 lines, -16 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Toon Verwaest
ptal
5 years, 1 month ago (2015-11-13 16:18:06 UTC) #2
Camillo Bruni
lgtm
5 years, 1 month ago (2015-11-13 16:21:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442643009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442643009/20001
5 years, 1 month ago (2015-11-13 16:33:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7719)
5 years, 1 month ago (2015-11-13 16:38:09 UTC) #8
Toon Verwaest
mstarzinger: ptal for src/compiler.
5 years, 1 month ago (2015-11-13 17:17:36 UTC) #10
Benedikt Meurer
LGTM on compiler.
5 years, 1 month ago (2015-11-16 11:51:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442643009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442643009/20001
5 years, 1 month ago (2015-11-16 11:52:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10155) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 1 month ago (2015-11-16 11:53:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442643009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442643009/40001
5 years, 1 month ago (2015-11-17 07:57:54 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-17 08:21:05 UTC) #20
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 08:21:39 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/07c1d181e7d8ec838ea5f97e0514ce2a426b1f88
Cr-Commit-Position: refs/heads/master@{#32023}

Powered by Google App Engine
This is Rietveld 408576698