third_party/WebKit/Source/core/dom/URLSearchParams.idl - Issue 1442643008: Implement 'URLSearchParams'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/URLSearchParams.idl

Issue 1442643008: Implement 'URLSearchParams' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sof Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://url.spec.whatwg.org/#interface-urlsearchparams

	6

	7 [

	8 Constructor(),
	philipj_slow 2015/11/16 12:15:46 Does the IDL compiler not support the [Constructor Does the IDL compiler not support the [Constructor(optional (USVString or URLSearchParams) init = "")] syntax from the spec? If not, can you make sure there's an issue block crbug.com/345506? Mike West 2015/11/16 14:12:10 I didn't think it would work, but it looks like it Show quoted text On 2015/11/16 at 12:15:46, philipj wrote: > Does the IDL compiler not support the [Constructor(optional (USVString or URLSearchParams) init = "")] syntax from the spec? If not, can you make sure there's an issue block crbug.com/345506? I didn't think it would work, but it looks like it might. Hooray!
	9 Constructor(URLSearchParams initial),

	10 Constructor(USVString queryString),

	11 GarbageCollected,

	12 Exposed=(Window,Worker)

	13 ] interface URLSearchParams {

	14 void append(USVString name, USVString value);

	15 [ImplementedAs=deleteAllWithName] void delete(USVString name);

	16 [TreatReturnedNullStringAs=Null] USVString get(USVString name);
	philipj_slow 2015/11/16 12:15:46 Can you use `USVString?` instead of `[TreatReturne Can you use `USVString?` instead of `[TreatReturnedNullStringAs=Null] USVString`? Mike West 2015/11/16 14:12:10 Sure. Show quoted text On 2015/11/16 at 12:15:46, philipj wrote: > Can you use `USVString?` instead of `[TreatReturnedNullStringAs=Null] USVString`? Sure.
	17 sequence<USVString> getAll(USVString name);

	18 boolean has(USVString name);

	19 void set(USVString name, USVString value);

	20
	philipj_slow 2015/11/16 12:15:46 Can you add a TODO for `iterable<USVString, USVStr Can you add a TODO for `iterable<USVString, USVString>`, or implement if it's not blocked on something? Mike West 2015/11/16 14:12:10 Sure. I even added a test! Show quoted text On 2015/11/16 at 12:15:46, philipj wrote: > Can you add a TODO for `iterable<USVString, USVString>`, or implement if it's not blocked on something? Sure. I even added a test!
	21 stringifier;

	22 };

OLD	NEW

« third_party/WebKit/Source/core/dom/URLSearchParams.h ('K') | « third_party/WebKit/Source/core/dom/URLSearchParams.cpp ('k') | no next file » | no next file with comments »