Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1442643002: [turbofan] Rename "original constructor" to "new target". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 02061a75145486fe8dd6b86310151329b7be91d0..0e74afca9adf44448b106904642bf98a2aabcdff 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -2041,7 +2041,7 @@ void BytecodeGenerator::VisitThisFunctionVariable(Variable* variable) {
// TODO(rmcilroy): Remove once we have tests which exercise this code path.
UNIMPLEMENTED();
- // Store the closure we were called with in the this_function_var.
+ // Store the closure we were called with in the given variable.
builder()->LoadAccumulatorWithRegister(Register::function_closure());
VisitVariableAssignment(variable, FeedbackVectorSlot::Invalid());
}
@@ -2050,8 +2050,8 @@ void BytecodeGenerator::VisitThisFunctionVariable(Variable* variable) {
void BytecodeGenerator::VisitNewTargetVariable(Variable* variable) {
if (variable == nullptr) return;
- // Store the closure we were called with in the this_function_var.
- builder()->CallRuntime(Runtime::kGetOriginalConstructor, Register(), 0);
+ // Store the new target we were called with in the given variable.
+ builder()->CallRuntime(Runtime::kGetNewTarget, Register(), 0);
VisitVariableAssignment(variable, FeedbackVectorSlot::Invalid());
}
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698