Chromium Code Reviews

Issue 1442643002: [turbofan] Rename "original constructor" to "new target". (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rename "original constructor" to "new target". This aligns the naming of "new target" with the spec text throughout TurboFan and the stack frame walker. The goal is to avoid unnecessary confusion for people familiar with the spec. R=verwaest@chromium.org Committed: https://crrev.com/83a6ab85cc48a6c230925604fa160be7c9a09efe Cr-Commit-Position: refs/heads/master@{#31978}

Patch Set 1 #

Patch Set 2 : Some more comments. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Stats (+71 lines, -81 lines)
M src/compiler/ast-graph-builder.cc View 3 chunks +4 lines, -5 lines 0 comments
M src/compiler/js-generic-lowering.cc View 1 chunk +5 lines, -5 lines 0 comments
M src/compiler/js-inlining.cc View 3 chunks +8 lines, -8 lines 0 comments
M src/frames.h View 2 chunks +4 lines, -4 lines 0 comments
M src/frames.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments
M src/interpreter/bytecode-generator.cc View 2 chunks +3 lines, -3 lines 0 comments
M src/runtime/runtime.h View 1 chunk +30 lines, -30 lines 0 comments
M src/runtime/runtime-function.cc View 2 chunks +3 lines, -3 lines 0 comments
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +4 lines, -5 lines 0 comments

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-12 13:14:03 UTC) #1
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-13 09:40:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442643002/40001
5 years, 1 month ago (2015-11-13 11:49:43 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-13 11:53:21 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:20 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/83a6ab85cc48a6c230925604fa160be7c9a09efe
Cr-Commit-Position: refs/heads/master@{#31978}

Powered by Google App Engine