Issue 1442583004: Revert of git_cl/gclient: use python2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1442583004: Revert of git_cl/gclient: use python2 (Closed)

Created:
5 years, 1 month ago by iannucci

Modified:
5 years, 1 month ago

Reviewers:
Sergey Berezin, vapier, ghost stip (do not use)

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Revert of git_cl/gclient: use python2 (patchset #3 id:40001 of https://codereview.chromium.org/1437773002/ ) Reason for revert: breaks git-bash on windows Original issue's description: > git_cl/gclient: use python2 > > Newer distros are defaulting /usr/bin/python to python3, so use python2 > explicitly so we continue working. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297535 TBR=stip@chromium.org,sergeyberezin@chromium.org,vapier@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297544

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	gclient	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gclient.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	git_cl.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/gclient_smoketest.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442583004/1

5 years, 1 month ago (2015-11-12 18:08:27 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297544

5 years, 1 month ago (2015-11-12 18:08:35 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages