Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1442583002: Revert of AudioPlayer: Update control panel with playback progress bar. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of AudioPlayer: Update control panel with playback progress bar. (patchset #2 id:20001 of https://codereview.chromium.org/1403303011/ ) Reason for revert: We decided to punt redesign of audio player to M49. Original issue's description: > AudioPlayer: Update control panel with playback progress bar. > > This CL includes: > - Replace custom progress bar with paper-slider. > - Pause track temporalily while dragging progress bar to be consistent with video player. > - Adjust layout of control panel. > - Show playing time as "{current} / {duration}". > > BUG=488229 > TEST=manually > > Committed: https://crrev.com/5c8f889bbbcc22b137b55e935e7d38f70c7e4ade > Cr-Commit-Position: refs/heads/master@{#357064} TBR=yawano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488229 Committed: https://crrev.com/5f691027fa2f7ea5f792308987a3ab166d58674c Cr-Commit-Position: refs/heads/master@{#359286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -106 lines) Patch
A ui/file_manager/audio_player/assets/100/player_timeline_base_center.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/100/player_timeline_base_left.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/100/player_timeline_base_right.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/100/player_timeline_handler_pressed.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/100/player_timeline_played_center.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/100/player_timeline_played_left.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/100/player_timeline_played_right.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_base_center.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_base_left.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_base_right.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_handler_pressed.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_played_center.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_played_left.png View Binary file 0 comments Download
A ui/file_manager/audio_player/assets/200/player_timeline_played_right.png View Binary file 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.css View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.js View 3 chunks +0 lines, -27 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.css View 3 chunks +181 lines, -35 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.html View 4 chunks +19 lines, -10 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 3 chunks +11 lines, -27 lines 0 comments Download
M ui/file_manager/audio_player/elements/track_list.css View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/audio_player/js/background.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fukino
Created Revert of AudioPlayer: Update control panel with playback progress bar.
5 years, 1 month ago (2015-11-12 08:33:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442583002/1
5 years, 1 month ago (2015-11-12 08:33:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 08:34:21 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:06:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f691027fa2f7ea5f792308987a3ab166d58674c
Cr-Commit-Position: refs/heads/master@{#359286}

Powered by Google App Engine
This is Rietveld 408576698