Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: third_party/WebKit/Source/web/ColorChooserPopupUIController.h

Issue 1442543003: Oilpan: trace ColorChooserPopupUIController::m_chromeClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: leave out unrelated code tidying Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ColorChooserPopupUIController.h
diff --git a/third_party/WebKit/Source/web/ColorChooserPopupUIController.h b/third_party/WebKit/Source/web/ColorChooserPopupUIController.h
index 155210b7d281309081e4949ab7d379745f3e581e..3099560172e5d737fcd4606a363c9c1a082ec0c2 100644
--- a/third_party/WebKit/Source/web/ColorChooserPopupUIController.h
+++ b/third_party/WebKit/Source/web/ColorChooserPopupUIController.h
@@ -37,7 +37,7 @@ class ColorChooserClient;
class PagePopup;
class ColorChooserPopupUIController final : public ColorChooserUIController, public PagePopupClient {
-
+ WILL_BE_USING_PRE_FINALIZER(ColorChooserPopupUIController, dispose);
public:
static PassOwnPtrWillBeRawPtr<ColorChooserPopupUIController> create(LocalFrame* frame, ChromeClientImpl* chromeClient, ColorChooserClient* client)
{
@@ -45,6 +45,7 @@ public:
}
~ColorChooserPopupUIController() override;
+ DECLARE_VIRTUAL_TRACE();
// ColorChooserUIController functions:
void openUI() override;
@@ -67,8 +68,9 @@ private:
ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserClient*);
void openPopup();
+ void dispose();
- ChromeClientImpl* m_chromeClient;
+ RawPtrWillBeMember<ChromeClientImpl> m_chromeClient;
PagePopup* m_popup;
Locale& m_locale;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698