Get rid of the use_glib gn variable.

Get rid of the use_glib gn variable.

I believe this also makes base_unittests build cleanly again (as in it
now does, and IIRC it didn't previously, due to a bug in //base/BUILD.gn
related to use_glib).

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/df7f866ce3da1ef3c212cde977a6a77dc832ce22

[viettrungluu, 2015-11-12 02:35:41]

https://codereview.chromium.org/1442523002/diff/1/base/BUILD.gn
File base/BUILD.gn (left):

https://codereview.chromium.org/1442523002/diff/1/base/BUILD.gn#oldcode1379
base/BUILD.gn:1379: if (!is_linux || use_ozone) {
This condition was obviously wrong.

https://codereview.chromium.org/1442523002/diff/1/ui/events/platform/x11/BUIL...
File ui/events/platform/x11/BUILD.gn (left):

https://codereview.chromium.org/1442523002/diff/1/ui/events/platform/x11/BUIL...
ui/events/platform/x11/BUILD.gn:11: "x11_event_source_glib.cc",
Note: This file doesn't actually currently exist.

[jamesr, 2015-11-12 02:37:44]

Hmm, use_glib was true for us on linux desktop builds.  It's not needed?

[jamesr, 2015-11-12 02:38:41]

https://codereview.chromium.org/1442523002/diff/1/base/BUILD.gn
File base/BUILD.gn (left):

https://codereview.chromium.org/1442523002/diff/1/base/BUILD.gn#oldcode1379
base/BUILD.gn:1379: if (!is_linux || use_ozone) {
On 2015/11/12 at 02:35:41, viettrungluu wrote:
> This condition was obviously wrong.

This is the same as !use_glib, i think, so it's trying to remove
message_pump_glib_unittest.cc when glib is not selected

[viettrungluu, 2015-11-12 14:35:49]

On 2015/11/12 02:37:44, jamesr wrote:
> Hmm, use_glib was true for us on linux desktop builds.  It's not needed?

No it wasn't. See the change to mopy/gn.py.

[viettrungluu, 2015-11-12 14:37:41]

On 2015/11/12 02:38:41, jamesr wrote:
> https://codereview.chromium.org/1442523002/diff/1/base/BUILD.gn
> File base/BUILD.gn (left):
> 
> https://codereview.chromium.org/1442523002/diff/1/base/BUILD.gn#oldcode1379
> base/BUILD.gn:1379: if (!is_linux || use_ozone) {
> On 2015/11/12 at 02:35:41, viettrungluu wrote:
> > This condition was obviously wrong.
> 
> This is the same as !use_glib, i think, so it's trying to remove
> message_pump_glib_unittest.cc when glib is not selected

It's trying, but it isn't (because use_glib can be set to false even for
is_linux && !use_ozone, i.e., our configuration). I guess in Chromium, use_glib
was always the same as is_linux && !use_ozone.

[jamesr, 2015-11-12 17:49:45]

lgtm

[viettrungluu, 2015-11-12 17:51:53]

Committed patchset #1 (id:1) manually as
df7f866ce3da1ef3c212cde977a6a77dc832ce22 (presubmit successful).