Handle expired Autofill credit cards in autofill dialog

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
@@ skipping 823 matching lines @@
 
 void AutofillDialogViews::UpdateProgressBar(double value) {
   autocheckout_progress_bar_->SetValue(value);
 }
 
 void AutofillDialogViews::ModelChanged() {
   menu_runner_.reset();
 
   for (DetailGroupMap::iterator iter = detail_groups_.begin();
        iter != detail_groups_.end(); ++iter) {
-    UpdateDetailsGroupState(iter->second);
+    UpdateDetailsGroupState(&iter->second);
   }
 }
 
 TestableAutofillDialogView* AutofillDialogViews::GetTestableView() {
   return this;
 }
 
 void AutofillDialogViews::SubmitForTesting() {
   Accept();
 }
@@ skipping 315 matching lines @@
 void AutofillDialogViews::CreateDetailsSection(DialogSection section) {
   // Inputs container (manual inputs + combobox).
   views::View* inputs_container = CreateInputsContainer(section);
 
   DetailsGroup* group = GroupForSection(section);
   // Container (holds label + inputs).
   group->container = new SectionContainer(
       controller_->LabelForSection(section),
       inputs_container,
       group->suggested_button);
-  UpdateDetailsGroupState(*group);
+  UpdateDetailsGroupState(group);
 }
 
 views::View* AutofillDialogViews::CreateInputsContainer(DialogSection section) {
   views::View* inputs_container = new views::View();
   views::GridLayout* layout = new views::GridLayout(inputs_container);
   inputs_container->SetLayoutManager(layout);
 
   int kColumnSetId = 0;
   views::ColumnSet* column_set = layout->AddColumnSet(kColumnSetId);
   column_set->AddColumn(views::GridLayout::FILL,
@@ skipping 141 matching lines @@
       views::Combobox* combobox = combo_mapping->second;
       for (int i = 0; i < combobox->model()->GetItemCount(); ++i) {
         if (input.initial_value == combobox->model()->GetItemAt(i)) {
           combobox->SetSelectedIndex(i);
           break;
         }
       }
     }
   }
 
-  UpdateDetailsGroupState(*group);
-  if (group->container && group->container->visible())
-    ValidateGroup(group, AutofillDialogController::VALIDATE_EDIT);
+  UpdateDetailsGroupState(group);
 }
 
-void AutofillDialogViews::UpdateDetailsGroupState(const DetailsGroup& group) {
+void AutofillDialogViews::UpdateDetailsGroupState(DetailsGroup* group) {
   const SuggestionState& suggestion_state =
-      controller_->SuggestionStateForSection(group.section);
+      controller_->SuggestionStateForSection(group->section);
   bool show_suggestions = !suggestion_state.text.empty();
-  group.suggested_info->SetVisible(show_suggestions);
-  group.suggested_info->SetSuggestionText(suggestion_state.text,
-                                          suggestion_state.text_style);
-  group.suggested_info->SetSuggestionIcon(suggestion_state.icon);
-  group.suggested_info->SetEditable(suggestion_state.editable);
+  group->suggested_info->SetVisible(show_suggestions);
+  group->suggested_info->SetSuggestionText(suggestion_state.text,
+                                           suggestion_state.text_style);
+  group->suggested_info->SetSuggestionIcon(suggestion_state.icon);
+  group->suggested_info->SetEditable(suggestion_state.editable);
 
   if (!suggestion_state.extra_text.empty()) {
-    group.suggested_info->ShowTextfield(
+    group->suggested_info->ShowTextfield(
         suggestion_state.extra_text,
         suggestion_state.extra_icon.AsImageSkia());
   }
 
-  group.manual_input->SetVisible(!show_suggestions);
+  group->manual_input->SetVisible(!show_suggestions);
 
   // Show or hide the "Save in chrome" checkbox. If nothing is in editing mode,
   // hide. If the controller tells us not to show it, likewise hide.
   save_in_chrome_checkbox_->SetVisible(
       controller_->ShouldOfferToSaveInChrome());
 
-  const bool has_suggestions =
-      controller_->MenuModelForSection(group.section)->GetItemCount() > 0;
+  const bool has_menu =
+      controller_->MenuModelForSection(group->section)->GetItemCount() > 0;
 
-  if (group.suggested_button)
-    group.suggested_button->SetVisible(has_suggestions);
+  if (group->suggested_button)
+    group->suggested_button->SetVisible(has_menu);
 
-  if (group.container) {
-    group.container->SetForwardMouseEvents(has_suggestions && show_suggestions);
-    group.container->SetVisible(controller_->SectionIsActive(group.section));
+  if (group->container) {
+    group->container->SetForwardMouseEvents(has_menu && show_suggestions);
+    group->container->SetVisible(controller_->SectionIsActive(group->section));
+    if (group->container->visible())
+      ValidateGroup(group, AutofillDialogController::VALIDATE_EDIT);
   }
 
   ContentsPreferredSizeChanged();
 }
 
 bool AutofillDialogViews::ValidateGroup(
     DetailsGroup* group,
     AutofillDialogController::ValidationType validation_type) {
   DCHECK(group->container->visible());
 
@@ skipping 184 matching lines @@
 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
     : section(section),
       container(NULL),
       manual_input(NULL),
       suggested_info(NULL),
       suggested_button(NULL) {}
 
 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
 
 }  // namespace autofill