Port video_decode_accelerator_unittest to GN for Android

Port video_decode_accelerator_unittest to GN for Android

BUG=510485
Committed: https://crrev.com/8c31609851193aca804b83b6d4f45e26c8f89f48
Cr-Commit-Position: refs/heads/master@{#361173}

[pkotwicz, 2015-11-12 00:30:28]

pkotwicz@chromium.org changed reviewers:
+ liberato@chromium.org

[pkotwicz, 2015-11-12 00:30:28]

liberato@ can you please take a look?

I did not port video_decode_accelerator_unittest to GN for:
- CrOS: because video_decode_accelerator_unittest needs to run on a device and
compiling CrOS for a device with GN is not yet supported. I believe
crbug.com/517496 tracks getting this working
- Windows: video_decode_accelerator_unittest did not pass for me when I built
with GYP

[pkotwicz, 2015-11-12 00:32:00]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-11-12 00:35:25]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2015-11-12 00:44:39]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2015-11-12 00:45:37]

Patchset #1 (id:60001) has been deleted

[liberato (no reviews please), 2015-11-12 17:15:33]

On 2015/11/12 00:30:28, pkotwicz wrote:
> liberato@ can you please take a look?
> 
> I did not port video_decode_accelerator_unittest to GN for:
> - CrOS: because video_decode_accelerator_unittest needs to run on a device and
> compiling CrOS for a device with GN is not yet supported. I believe
> crbug.com/517496 tracks getting this working
> - Windows: video_decode_accelerator_unittest did not pass for me when I built
> with GYP

lgtm.

thanks for taking the time with this.

[liberato (no reviews please), 2015-11-12 17:17:25]

On 2015/11/12 17:15:33, liberato wrote:
> On 2015/11/12 00:30:28, pkotwicz wrote:
> > liberato@ can you please take a look?
> > 
> > I did not port video_decode_accelerator_unittest to GN for:
> > - CrOS: because video_decode_accelerator_unittest needs to run on a device
and
> > compiling CrOS for a device with GN is not yet supported. I believe
> > crbug.com/517496 tracks getting this working
> > - Windows: video_decode_accelerator_unittest did not pass for me when I
built
> > with GYP
> 
> lgtm.
> 
> thanks for taking the time with this.

also note that i'm not an owner in content,

[pkotwicz, 2015-11-12 17:54:05]

pkotwicz@chromium.org changed reviewers:
+ brettw@chromium.org

[pkotwicz, 2015-11-12 17:54:06]

brettw@ for OWNERS

[pkotwicz, 2015-11-18 03:15:32]

brettw@ Ping!

[pkotwicz, 2015-11-20 15:44:18]

Description was changed from

==========
Port video_decode_accelerator_unittest to GN for Android

BUG=510485
==========

to

==========
Port video_decode_accelerator_unittest to GN for Android

BUG=510485
==========

[pkotwicz, 2015-11-20 15:44:18]

pkotwicz@chromium.org changed reviewers:
+ jochen@chromium.org

[pkotwicz, 2015-11-20 15:44:40]

jochen@ can you please take a look? brettw@ seems to be busy.

[brettw, 2015-11-20 22:04:18]

brettw@chromium.org changed reviewers:
- jochen@chromium.org

[brettw, 2015-11-20 22:04:19]

Sorry I was slow, removing jochen. LGTM with fix.

https://codereview.chromium.org/1442473002/diff/80001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/1442473002/diff/80001/content/content_tests.g...
content/content_tests.gypi:1658: # TODO(GN): Port Windows and ChromeOS logic.
Can you delete this TODO comment? We've been standardizing on TODO(GYP) in the
GN files (which it looks like you added) as the thing to grep for.

https://codereview.chromium.org/1442473002/diff/80001/content/test/BUILD.gn
File content/test/BUILD.gn (right):

https://codereview.chromium.org/1442473002/diff/80001/content/test/BUILD.gn#n...
content/test/BUILD.gn:842: include_dirs = [ "//third_party/khronos" ]
You should almost never have to write include dir constants to avoid duplicating
stuff all over. For this case:
  configs += [ "//third_party/khronos:khronos_headers" ]

[pkotwicz, 2015-11-23 18:37:18]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-11-23 18:37:18]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/1442473002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-11-23 18:37:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1442473002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1442473002/100001

[commit-bot: I haz the power, 2015-11-23 20:31:01]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2015-11-23 20:31:51]

Patchset 2 (id:??) landed as
https://crrev.com/8c31609851193aca804b83b6d4f45e26c8f89f48
Cr-Commit-Position: refs/heads/master@{#361173}