Issue 1442463005: Revert "Make GlobalEventHandlers not inherit from EventTarget"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1442463005: Revert "Make GlobalEventHandlers not inherit from EventTarget" (Closed)

Created:
5 years, 1 month ago by Alan Knight

Modified:
5 years, 1 month ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1, sra1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Make GlobalEventHandlers not inherit from EventTarget" This reverts commit 4d2191990e45240e9d9cb5cb31257c3b93f252a4. BUG= Committed: https://github.com/dart-lang/sdk/commit/65dfa74dd4238d9ef9c8a51e38883062ee367574

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_GlobalEventHandlers.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Alan Knight

Breaks analysis with the method bodies in there. Needs a bit more cleverness to work.

5 years, 1 month ago (2015-11-12 23:29:35 UTC) #2

Alan Knight

5 years, 1 month ago (2015-11-12 23:29:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
65dfa74dd4238d9ef9c8a51e38883062ee367574 (presubmit successful).