chrome/test/data/save_page/frames-objects.htm - Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/save_page/frames-objects.htm

Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@objects-fix-for-complete-html

Patch Set: s/\<u\>/element_url/g in savable_resources.cc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head><title>Object elements test</title></head>	3 <head><title>Object elements test</title></head>

4 <body>	4 <body>

5 Content verification marker:	5 Content verification marker:

6 frames-objects.htm: 8da13db4-a512-4d9b-b1c5-dc1c134234b9	6 frames-objects.htm: 8da13db4-a512-4d9b-b1c5-dc1c134234b9

7 <br>	7 <br>

8 <br>	8 <br>

9	9

10 Html object:	10 Html object:

11 <br>	11 <br>

12 <object data="b.htm" border="1">err_no_object_data</object>	12 <object data="frames-nested.htm" border="1">err_no_object_data</object>

13 <br>	13 <br>

14 <br>	14 <br>

15	15

16 Regular iframe:	16 Regular iframe:

17 <br>	17 <br>

18 <iframe src="a.htm" border="1"></iframe>	18 <iframe src="a.htm" border="1"></iframe>

19 <br>	19 <br>

20 <br>	20 <br>

21	21

22 Png object:	22 Png object:

23 <br>	23 <br>

24 <object data="png.png" border="1">err_no_object_data</object>	24 <object data="png.png" border="1">err_no_object_data</object>

25 <br>	25 <br>

26 <br>	26 <br>

27	27

28 Pdf object:	28 Pdf object:

29 <br>	29 <br>

30 <object data="pdf.pdf" border="1">err_no_object_data</object>	30 <object data="pdf.pdf" border="1">err_no_object_data</object>

31 <br>	31 <br>

32 <br>	32 <br>

33	33

34 Svg object:	34 Svg object:

35 <br>	35 <br>

36 <object data="svg.svg" border="1">err_no_object_data</object>	36 <object data="svg.svg" border="1">err_no_object_data</object>

37 <br>	37 <br>

38 <br>	38 <br>

39	39

40 </body>	40 </body>

41 </html>	41 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/renderer/savable_resources.cc » ('j') | content/renderer/savable_resources.cc » ('J')