Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9396)

Unified Diff: chrome/renderer/resources/neterror.js

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update button color for "Show all saved pages" per UI review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/neterror.js
diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js
index 5bab31d8da46ce7cf8399407c02e5649ad3c0efa..773d82fb4ba50a14b00888fec86b224300d330c6 100644
--- a/chrome/renderer/resources/neterror.js
+++ b/chrome/renderer/resources/neterror.js
@@ -114,9 +114,15 @@ function showSavedCopyButtonClick() {
}
}
-function showSavedPagesButtonClick() {
+function showOfflinePagesButtonClick() {
if (window.errorPageController) {
- errorPageController.showSavedPagesButtonClick();
+ errorPageController.showOfflinePagesButtonClick();
+ }
+}
+
+function showOfflineCopyButtonClick() {
+ if (window.errorPageController) {
+ errorPageController.showOfflineCopyButtonClick();
}
}
@@ -156,27 +162,29 @@ function onDocumentLoad() {
var reloadButton = document.getElementById('reload-button');
var detailsButton = document.getElementById('details-button');
var showSavedCopyButton = document.getElementById('show-saved-copy-button');
- var showSavedPagesButton = document.getElementById('show-saved-pages-button');
+ var showOfflinePagesButton =
+ document.getElementById('show-offline-pages-button');
+ var showOfflineCopyButton =
+ document.getElementById('show-offline-copy-button');
- // "Show save pages" button will only be provided in ERR_INTERNET_DISCONNECTED
- // page where "Reload" button will not be provided.
var reloadButtonVisible = loadTimeData.valueExists('reloadButton') &&
loadTimeData.getValue('reloadButton').msg;
var showSavedCopyButtonVisible =
loadTimeData.valueExists('showSavedCopyButton') &&
loadTimeData.getValue('showSavedCopyButton').msg;
- var showSavedPagesButtonVisible =
- loadTimeData.valueExists('showSavedPagesButton') &&
- loadTimeData.getValue('showSavedPagesButton').msg;
+ var showOfflinePagesButtonVisible =
+ loadTimeData.valueExists('showOfflinePagesButton') &&
+ loadTimeData.getValue('showOfflinePagesButton').msg;
+ var showOfflineCopyButtonVisible =
+ loadTimeData.valueExists('showOfflineCopyButton') &&
+ loadTimeData.getValue('showOfflineCopyButton').msg;
var primaryButton, secondaryButton;
if (showSavedCopyButton.primary) {
primaryButton = showSavedCopyButton;
- secondaryButton =
- showSavedPagesButtonVisible ? showSavedPagesButton : reloadButton;
+ secondaryButton = reloadButton;
} else {
- primaryButton =
- showSavedPagesButtonVisible ? showSavedPagesButton : reloadButton;
+ primaryButton = reloadButton;
secondaryButton = showSavedCopyButton;
}
@@ -196,7 +204,8 @@ function onDocumentLoad() {
if (reloadButton.style.display == 'none' &&
showSavedCopyButton.style.display == 'none' &&
- showSavedPagesButton.style.display == 'none') {
+ showOfflinePagesButton.style.display == 'none' &&
+ showOfflineCopyButton.style.display == 'none') {
detailsButton.classList.add('singular');
}
@@ -210,11 +219,12 @@ function onDocumentLoad() {
// Show control buttons.
if (reloadButtonVisible || showSavedCopyButtonVisible ||
- showSavedPagesButtonVisible) {
+ showOfflinePagesButtonVisible || showOfflineCopyButton) {
controlButtonDiv.hidden = false;
// Set the secondary button state in the cases of two call to actions.
- if ((reloadButtonVisible || showSavedPagesButtonVisible) &&
+ if ((reloadButtonVisible || showOfflinePagesButtonVisible ||
+ showOfflineCopyButton) &&
showSavedCopyButtonVisible) {
secondaryButton.classList.add('secondary-button');
}
« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | components/error_page.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698