Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6996)

Unified Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update button color for "Show all saved pages" per UI review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/net/net_error_page_controller.cc
diff --git a/chrome/renderer/net/net_error_page_controller.cc b/chrome/renderer/net/net_error_page_controller.cc
index f9a2ed38989c2844089adcb94a02dcfe3e71cc23..be4aae4ab7281a301c0012c01897704a15b34d6a 100644
--- a/chrome/renderer/net/net_error_page_controller.cc
+++ b/chrome/renderer/net/net_error_page_controller.cc
@@ -43,8 +43,12 @@ bool NetErrorPageController::ShowSavedCopyButtonClick() {
return ButtonClick(error_page::NetErrorHelperCore::SHOW_SAVED_COPY_BUTTON);
}
-bool NetErrorPageController::ShowSavedPagesButtonClick() {
- return ButtonClick(error_page::NetErrorHelperCore::SHOW_SAVED_PAGES_BUTTON);
+bool NetErrorPageController::ShowOfflinePagesButtonClick() {
+ return ButtonClick(error_page::NetErrorHelperCore::SHOW_OFFLINE_PAGES_BUTTON);
+}
+
+bool NetErrorPageController::ShowOfflineCopyButtonClick() {
+ return ButtonClick(error_page::NetErrorHelperCore::SHOW_OFFLINE_COPY_BUTTON);
}
bool NetErrorPageController::ReloadButtonClick() {
@@ -96,18 +100,18 @@ gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
isolate)
.SetMethod("showSavedCopyButtonClick",
&NetErrorPageController::ShowSavedCopyButtonClick)
- .SetMethod("showSavedPagesButtonClick",
- &NetErrorPageController::ShowSavedPagesButtonClick)
+ .SetMethod("showOfflinePagesButtonClick",
+ &NetErrorPageController::ShowOfflinePagesButtonClick)
+ .SetMethod("showOfflineCopyButtonClick",
+ &NetErrorPageController::ShowOfflineCopyButtonClick)
.SetMethod("reloadButtonClick",
&NetErrorPageController::ReloadButtonClick)
.SetMethod("detailsButtonClick",
&NetErrorPageController::DetailsButtonClick)
.SetMethod("diagnoseErrorsButtonClick",
&NetErrorPageController::DiagnoseErrorsButtonClick)
- .SetMethod("trackClick",
- &NetErrorPageController::TrackClick)
- .SetMethod("trackEasterEgg",
- &NetErrorPageController::TrackEasterEgg)
+ .SetMethod("trackClick", &NetErrorPageController::TrackClick)
+ .SetMethod("trackEasterEgg", &NetErrorPageController::TrackEasterEgg)
.SetMethod("trackCachedCopyButtonClick",
&NetErrorPageController::TrackCachedCopyButtonClick);
}
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698