Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybots Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_unittest.cc
diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc
index 2da4fd07b3a93630d4b851b3d9ec980c76d771bb..d1c79ddc71777c08df81f3f1e3b4587052ace94f 100644
--- a/components/offline_pages/offline_page_model_unittest.cc
+++ b/components/offline_pages/offline_page_model_unittest.cc
@@ -388,10 +388,12 @@ TEST_F(OfflinePageModelTest, SavePageSuccessful) {
BuildArchiver(kTestUrl,
OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
.Pass());
+ EXPECT_FALSE(model()->HasOfflinePages());
model()->SavePage(
kTestUrl, kTestPageBookmarkId1, archiver.Pass(),
base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
PumpLoop();
+ EXPECT_TRUE(model()->HasOfflinePages());
OfflinePageTestStore* store = GetStore();
EXPECT_EQ(kTestUrl, store->last_saved_page().url);
@@ -841,6 +843,44 @@ TEST_F(OfflinePageModelTest, GetPageByOfflineURL) {
EXPECT_FALSE(page);
}
+TEST_F(OfflinePageModelTest, GetPageByOnlineURL) {
+ scoped_ptr<OfflinePageTestArchiver> archiver(
+ BuildArchiver(kTestUrl,
+ OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
+ .Pass());
+ model()->SavePage(
+ kTestUrl, kTestPageBookmarkId1, archiver.Pass(),
+ base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
+ PumpLoop();
+
+ OfflinePageTestStore* store = GetStore();
+ GURL offline_url = store->last_saved_page().GetOfflineURL();
fgorski 2015/11/20 23:09:46 Do you need this?
jianli 2015/11/23 22:08:34 Removed.
+
+ scoped_ptr<OfflinePageTestArchiver> archiver2(
+ BuildArchiver(kTestUrl2,
+ OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED)
+ .Pass());
+ model()->SavePage(
+ kTestUrl2, kTestPageBookmarkId2, archiver2.Pass(),
+ base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
+ PumpLoop();
+
+ GURL offline_url2 = store->last_saved_page().GetOfflineURL();
fgorski 2015/11/20 23:09:46 And that one.
jianli 2015/11/23 22:08:34 Removed.
+
+ const OfflinePageItem* page = model()->GetPageByOnlineURL(kTestUrl2);
+ EXPECT_TRUE(page);
+ EXPECT_EQ(kTestUrl2, page->url);
+ EXPECT_EQ(kTestPageBookmarkId2, page->bookmark_id);
+
+ page = model()->GetPageByOnlineURL(kTestUrl);
+ EXPECT_TRUE(page);
+ EXPECT_EQ(kTestUrl, page->url);
+ EXPECT_EQ(kTestPageBookmarkId1, page->bookmark_id);
+
+ page = model()->GetPageByOnlineURL(GURL("http://foo"));
+ EXPECT_FALSE(page);
+}
+
// Test that model returns pages that are older than 30 days as candidates for
// clean up, hence the numbers in time delta.
TEST_F(OfflinePageModelTest, GetPagesToCleanUp) {

Powered by Google App Engine
This is Rietveld 408576698