Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: components/error_page/common/offline_page_types.h

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybots Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/error_page/common/offline_page_types.h
diff --git a/components/error_page/common/offline_page_types.h b/components/error_page/common/offline_page_types.h
new file mode 100644
index 0000000000000000000000000000000000000000..c686238f5acc68feffd37f179a9a236727bb490b
--- /dev/null
+++ b/components/error_page/common/offline_page_types.h
@@ -0,0 +1,22 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
nasko 2015/11/17 16:42:24 No "(c)" needed.
jianli 2015/11/19 02:23:46 I didn't realize that we had dropped (c) part. Rem
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_ERROR_PAGE_COMMON_OFFLINE_PAGE_TYPES_H_
+#define COMPONENTS_ERROR_PAGE_COMMON_OFFLINE_PAGE_TYPES_H_
+
+namespace error_page {
+
+enum class OfflinePageStatus {
+ // No offline page exists.
+ NONE,
+ // The offline copy of current page exists.
mmenke 2015/11/17 21:02:15 nit: The -> An
jianli 2015/11/19 02:23:46 Done.
+ HAS_PAGE_COPY,
mmenke 2015/11/17 21:02:15 I'd say HAS_PAGE or HAS_OFFLINE_PAGE ("Offline" an
jianli 2015/11/19 02:23:46 Changed to HAS_OFFLINE_PAGE.
+ // The offline copy of current page does not exist, but the offline copies of
mmenke 2015/11/17 21:02:15 nit: The -> An
jianli 2015/11/19 02:23:46 Done.
+ // other pages exist.
+ HAS_OTHER_PAGES_COPIES,
mmenke 2015/11/17 21:02:15 Suggest HAS_OTHER_PAGES or HAS_OTHER_OFFLINE_PAGES
jianli 2015/11/19 02:23:46 Changed to HAS_OTHER_OFFLINE_PAGES.
+};
+
+} // namespace error_page
+
+#endif // COMPONENTS_ERROR_PAGE_COMMON_OFFLINE_PAGE_TYPES_H_

Powered by Google App Engine
This is Rietveld 408576698