chrome/renderer/net/net_error_page_controller.h - Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/net/net_error_page_controller.h

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/net/net_error_helper.h ('K') | « chrome/renderer/net/net_error_helper.cc ('k') | chrome/renderer/net/net_error_page_controller.cc » ('j') | components/error_page/renderer/net_error_helper_core.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/net/net_error_page_controller.h

diff --git a/chrome/renderer/net/net_error_page_controller.h b/chrome/renderer/net/net_error_page_controller.h

index 95216cbfa3824aaa56c19a65de5eba03f357ba87..59dceb2cd8e8adac81d8abbbefe837cd767f0cbf 100644

--- a/chrome/renderer/net/net_error_page_controller.h

+++ b/chrome/renderer/net/net_error_page_controller.h

@@ -54,8 +54,11 @@ class NetErrorPageController : public gin::Wrappable<NetErrorPageController> {

// Execute a "Show saved copy" button click.

bool ShowSavedCopyButtonClick();

- // Execute a "Show saved pages" button click.

- bool ShowSavedPagesButtonClick();

+ // Execute a button click to show the list of all offline pages.

+ bool ShowOfflinePagesButtonClick();

+ // Execute a button click to show the offline copy of this page.

+ bool ShowOfflineCopyButtonClick();

// Execute a "Reload" button click.

bool ReloadButtonClick();