Add "Show saved copy" button in dino page when there's offline copy

chrome/common/localized_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/localized_error.h"
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 536 matching lines @@
 }  // namespace
 
 const char LocalizedError::kHttpErrorDomain[] = "http";
 
 void LocalizedError::GetStrings(int error_code,
                                 const std::string& error_domain,
                                 const GURL& failed_url,
                                 bool is_post,
                                 bool stale_copy_in_cache,
                                 bool can_show_network_diagnostics_dialog,
-                                bool has_offline_pages,
+                                OfflinePageStatus offline_page_status,
                                 const std::string& locale,
                                 const std::string& accept_languages,
                                 scoped_ptr<error_page::ErrorPageParams> params,
                                 base::DictionaryValue* error_strings) {
   webui::SetLoadTimeDataDefaults(locale, error_strings);
 
   // Grab the strings and settings that depend on the error type.  Init
   // options with default values.
   LocalizedErrorMap options = {
     0,
@@ skipping 193 matching lines @@
             IDS_ERRORPAGES_BUTTON_SHOW_SAVED_COPY));
     show_saved_copy_button->SetString(
         "title",
         l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_SAVED_COPY_HELP));
     if (show_saved_copy_primary)
       show_saved_copy_button->SetString("primary", "true");
     error_strings->Set("showSavedCopyButton", show_saved_copy_button);
   }
 
 #if defined(OS_ANDROID)
-  if (has_offline_pages) {
-    base::DictionaryValue* show_saved_pages_button = new base::DictionaryValue;
-    show_saved_pages_button->SetString(
-        "msg",
-        l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_SAVED_PAGES));
-    show_saved_pages_button->SetString(
-        "title",
-        l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_SAVED_PAGES));
-    error_strings->Set("showSavedPagesButton", show_saved_pages_button);
+  if (offline_page_status == OfflinePageStatus::HAS_PAGE_COPY) {
+    base::DictionaryValue* show_offline_copy_button = new base::DictionaryValue;
+    base::string16 button_text =
+        l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_COPY);
+    show_offline_copy_button->SetString("msg", button_text);
+    show_offline_copy_button->SetString("title", button_text);
+    error_strings->Set("showOfflineCopyButton", show_offline_copy_button);

[mmenke, 2015/11/12 19:55:18]

What's the difference between an offline copy and a saved copy, just above?

[jianli, 2015/11/12 21:16:16]

If offline pages feature is on, we're going to show offline related button as:
1) If there is an offline copy of current page, "Show saved copy" button will be
provided. Note that the button text is same as the one for showing saved copy in
the cached (decided by the UI people).
2) Otherwise, "Show all saved pages" button will be provided when there is
offline copies saved for other pages.

To differentiate from saved copy in the cache feature, I decided to name offline
related stuff as "offline ***". So I renamed "saved pages" to "offline pages"
and called the new "saved copy" as "offline copy".

Also, when there is something to show in the cache, neither of offline button
will be offered.

+  } else if (offline_page_status == OfflinePageStatus::HAS_OTHER_COPIES) {
+    base::DictionaryValue* show_offline_pages_button =
+        new base::DictionaryValue;
+    base::string16 button_text =
+        l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_PAGES);
+    show_offline_pages_button->SetString("msg", button_text);
+    show_offline_pages_button->SetString("title", button_text);
+    error_strings->Set("showOfflinePagesButton", show_offline_pages_button);
   }
 #endif
 
 #if defined(OS_CHROMEOS)
   // ChromeOS has its own diagnostics extension, which doesn't rely on a
   // browser-initiated dialog.
   can_show_network_diagnostics_dialog = true;
 #endif
   if (can_show_network_diagnostics_dialog && failed_url.is_valid() &&
       failed_url.SchemeIsHTTPOrHTTPS()) {
@@ skipping 136 matching lines @@
     return l10n_util::GetStringUTF16(IDS_ERRORPAGES_DETAILS_UNKNOWN);
 }
 
 bool LocalizedError::HasStrings(const std::string& error_domain,
                                 int error_code) {
   // Whether or not the there are strings for an error does not depend on
   // whether or not the page was be generated by a POST, so just claim it was
   // not.
   return LookupErrorMap(error_domain, error_code, /*is_post=*/false) != NULL;
 }