tools/metrics/histograms/histograms.xml - Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address more feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 1148585b1ea7de52dc2831c07127e83134978244..2493f0fe82fd92d483ea1794113a922e6aca7a4f 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -68087,9 +68087,10 @@ To add a new entry, add it with any value and run test to compute valid value.

- <int value="18" label="Show Saved Pages Button Shown"/>

- <int value="19" label="Show Saved Pages Button Clicked"/>

- <int value="20" label="Show Saved Pages Button Click Load Error"/>

Ilya Sherman 2015/11/14 00:50:13 What happened to this case?

Ilya Sherman 2015/11/14 00:53:38 Per offline conversation, this case was never used

+ <int value="18" label="Show Offline Pages Button Shown"/>

+ <int value="19" label="Show Offline Pages Button Clicked"/>

+ <int value="20" label="Show Offline Copy Button Shown"/>

+ <int value="21" label="Show Offline Copy Button Shown"/>

nasko 2015/11/14 00:43:49 Clicked.

jianli 2015/11/17 00:06:49 Done.

</enum>

« chrome/browser/android/tab_android.cc ('K') | « components/error_page/renderer/net_error_helper_core_unittest.cc ('k') | no next file » | no next file with comments »