Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 144243004: Fix cr-bash-helpers for Mac w/ Homebrew, which doesn't have realpath. (Closed)

Created:
6 years, 10 months ago by Jeffrey Yasskin
Modified:
6 years, 10 months ago
Reviewers:
bulach, ian_cottrell
CC:
chromium-reviews
Visibility:
Public.

Description

Fix cr-bash-helpers for Mac w/ Homebrew, which doesn't have realpath. readlink is in gnu coreutils, which should be more widely available. On my machine, the gnu version is prefixed with 'g', while 'readlink' is a crippled Mac version without the -e option. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248853

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix formatting nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/cr/cr-bash-helpers.sh View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Jeffrey Yasskin
It looks like `cr` doesn't actually work on Mac, but here's one step closer.
6 years, 10 months ago (2014-02-03 23:07:25 UTC) #1
bulach
+ian, de facto owner...and lgtm % nit, thanks! https://codereview.chromium.org/144243004/diff/1/tools/cr/cr-bash-helpers.sh File tools/cr/cr-bash-helpers.sh (right): https://codereview.chromium.org/144243004/diff/1/tools/cr/cr-bash-helpers.sh#newcode19 tools/cr/cr-bash-helpers.sh:19: READLINK_e="greadlink ...
6 years, 10 months ago (2014-02-04 05:51:24 UTC) #2
Jeffrey Yasskin
https://codereview.chromium.org/144243004/diff/1/tools/cr/cr-bash-helpers.sh File tools/cr/cr-bash-helpers.sh (right): https://codereview.chromium.org/144243004/diff/1/tools/cr/cr-bash-helpers.sh#newcode19 tools/cr/cr-bash-helpers.sh:19: READLINK_e="greadlink -e" On 2014/02/04 05:51:25, bulach wrote: > nit: ...
6 years, 10 months ago (2014-02-04 06:59:03 UTC) #3
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 10 months ago (2014-02-04 16:46:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/144243004/60001
6 years, 10 months ago (2014-02-04 16:48:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:37:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=220741
6 years, 10 months ago (2014-02-04 17:37:06 UTC) #7
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 10 months ago (2014-02-04 17:39:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/144243004/60001
6 years, 10 months ago (2014-02-04 17:42:12 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 19:28:37 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=121016
6 years, 10 months ago (2014-02-04 19:28:38 UTC) #11
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 10 months ago (2014-02-04 21:46:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/144243004/60001
6 years, 10 months ago (2014-02-04 22:29:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/144243004/60001
6 years, 10 months ago (2014-02-05 01:04:21 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 05:05:18 UTC) #15
Message was sent while issue was closed.
Change committed as 248853

Powered by Google App Engine
This is Rietveld 408576698