Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1442343002: Remove the WebGlyphCache API. (Closed)

Created:
5 years, 1 month ago by esprehn
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the WebGlyphCache API. Lets just use Platform's histogramCustomCounts API. It's not as pretty but it simplifies down the surface of the Web API. This UMA also seems of very suspect value, perhaps we can just remove it soon. BUG=555870 Committed: https://crrev.com/78e1c1aa7a3612e709e1753fbca5f46d6647615a Cr-Commit-Position: refs/heads/master@{#359889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -103 lines) Patch
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/web/WebGlyphCache.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/web/WebGlyphCache.h View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442343002/1
5 years, 1 month ago (2015-11-13 23:25:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-14 01:22:33 UTC) #4
esprehn
5 years, 1 month ago (2015-11-14 01:25:56 UTC) #6
dglazkov
On 2015/11/14 at 01:25:56, esprehn wrote: > I wonder who put this counter in?
5 years, 1 month ago (2015-11-14 01:26:58 UTC) #7
dglazkov
lgtm
5 years, 1 month ago (2015-11-14 01:27:02 UTC) #8
esprehn
On 2015/11/14 at 01:26:58, dglazkov wrote: > On 2015/11/14 at 01:25:56, esprehn wrote: > > ...
5 years, 1 month ago (2015-11-14 01:37:18 UTC) #10
kinuko
lgtm
5 years, 1 month ago (2015-11-14 01:50:47 UTC) #11
dglazkov
On 2015/11/14 at 01:37:18, esprehn wrote: > On 2015/11/14 at 01:26:58, dglazkov wrote: > > ...
5 years, 1 month ago (2015-11-14 01:52:14 UTC) #12
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-16 11:57:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442343002/1
5 years, 1 month ago (2015-11-16 17:18:32 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 19:16:01 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 19:16:46 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78e1c1aa7a3612e709e1753fbca5f46d6647615a
Cr-Commit-Position: refs/heads/master@{#359889}

Powered by Google App Engine
This is Rietveld 408576698