Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt

Issue 144233008: Add [OverrideBuiltins] to HTMLCollection IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline failing test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.idl » ('j') | Source/core/html/HTMLCollection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt
diff --git a/LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt b/LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt
index 9cf751c28b8eed981e6093cf1bfb710b30c70ab3..e3f8328bda999b16f603da8ec375ece7ce633fbb 100644
--- a/LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt
+++ b/LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt
@@ -13,7 +13,7 @@ PASS form.elements[1].name is 'length'
PASS select.options.length is 2
PASS select.options[0].getAttribute('name') is 'length'
PASS select.options[1] is select.options['some']
-PASS table.rows.length is 2
+FAIL table.rows.length should be 2 (of type number). Was [object HTMLTableRowElement] (of type object).
arv (Not doing code reviews) 2014/02/05 20:53:05 Speed over correctness makes me sad :'(
Inactive 2014/02/05 20:58:47 I know... To be fair, we are returning HTMLCollect
PASS table.rows[0] is table.rows['another']
PASS table.rows[1].id is 'length'
PASS successfullyParsed is true
« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.idl » ('j') | Source/core/html/HTMLCollection.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698