Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Side by Side Diff: LayoutTests/fast/dom/collection-length-should-not-be-overridden-expected.txt

Issue 144233008: Add [OverrideBuiltins] to HTMLCollection IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline failing test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.idl » ('j') | Source/core/html/HTMLCollection.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 This test ensures the builtin length property of HTMLCollection's subclasses is not overridden by a named getter of the same name. 1 This test ensures the builtin length property of HTMLCollection's subclasses is not overridden by a named getter of the same name.
2 2
3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ". 3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
4 4
5 5
6 PASS documentAllLength is 18 6 PASS documentAllLength is 18
7 PASS documentAll5 is documentAllSome 7 PASS documentAll5 is documentAllSome
8 PASS documentAll6.name is 'length' 8 PASS documentAll6.name is 'length'
9 PASS form.length is form.elements[1] 9 PASS form.length is form.elements[1]
10 PASS form.elements.length is 2 10 PASS form.elements.length is 2
11 PASS form.elements[0] is form.elements['some'] 11 PASS form.elements[0] is form.elements['some']
12 PASS form.elements[1].name is 'length' 12 PASS form.elements[1].name is 'length'
13 PASS select.options.length is 2 13 PASS select.options.length is 2
14 PASS select.options[0].getAttribute('name') is 'length' 14 PASS select.options[0].getAttribute('name') is 'length'
15 PASS select.options[1] is select.options['some'] 15 PASS select.options[1] is select.options['some']
16 PASS table.rows.length is 2 16 FAIL table.rows.length should be 2 (of type number). Was [object HTMLTableRowEle ment] (of type object).
arv (Not doing code reviews) 2014/02/05 20:53:05 Speed over correctness makes me sad :'(
Inactive 2014/02/05 20:58:47 I know... To be fair, we are returning HTMLCollect
17 PASS table.rows[0] is table.rows['another'] 17 PASS table.rows[0] is table.rows['another']
18 PASS table.rows[1].id is 'length' 18 PASS table.rows[1].id is 'length'
19 PASS successfullyParsed is true 19 PASS successfullyParsed is true
20 20
21 TEST COMPLETE 21 TEST COMPLETE
22 22
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.idl » ('j') | Source/core/html/HTMLCollection.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698