Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: ui/events/ozone/event_converter_ozone.h

Issue 144233006: evdev: Fix infinite loop when devices are unplugged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/ozone/event_converter_ozone.h
diff --git a/ui/events/ozone/event_converter_ozone.h b/ui/events/ozone/event_converter_ozone.h
index 90826c26580d341ab94c7116edea219315ea51de..4dd99edd5dee9c8bc953afc256537b1387ab85ec 100644
--- a/ui/events/ozone/event_converter_ozone.h
+++ b/ui/events/ozone/event_converter_ozone.h
@@ -6,25 +6,26 @@
#define UI_EVENTS_OZONE_EVENT_CONVERTER_OZONE_H_
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_pump_libevent.h"
#include "ui/events/events_export.h"
namespace ui {
class Event;
-// In ozone, Chrome reads events from file descriptors created from Linux device
-// drivers. The |MessagePumpLibevent::Watcher| parent class provides the
-// functionality to watch a file descriptor for the arrival of new data and
-// notify its subclasses. Device-specific event converters turn bytes read from
-// the file descriptor into |ui::Event| instances. This class provides the
-// functionality needed in common across all converters: dispatching the
-// |ui::Event| to aura.
-class EVENTS_EXPORT EventConverterOzone
- : public base::MessagePumpLibevent::Watcher {
+// Ozone implementations can generate input events in whatever way is
+// appropriate for the platform.
+// This class provides the functionality needed in common across all
+// converters: dispatching the |ui::Event| to aura.
+class EVENTS_EXPORT EventConverterOzone {
public:
EventConverterOzone();
virtual ~EventConverterOzone();
+ // Start processing events.
rjkroege 2014/01/27 19:03:16 Is it re-startable? I.e.: would one ever call Stop
+ virtual void Start() = 0;
+
+ // Stop processing events.
+ virtual void Stop() = 0;
+
protected:
// Subclasses should use this method to post a task that will dispatch
// |event| from the UI message loop. This method takes ownership of

Powered by Google App Engine
This is Rietveld 408576698