Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1442273002: Fix "[turbofan] Spill rsi and rdi in their existing locations." (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix "[turbofan] Spill rsi and rdi in their existing locations." Commit 20f3a0778299c0fd0c6e7ce955a14d800973c152 broke platforms using embedded constant pools due to assumptions regarding stack frame layout. R=mtrofin@chromium.org, bmeurer@chromium.org, jarin@chromium.org, michael_dawson@ca.ibm.com BUG=v8:4548 LOG=n Committed: https://crrev.com/61a39335c6c315e26f8f8f35bf278266ffcecd6f Cr-Commit-Position: refs/heads/master@{#31996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/frame.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-13 22:11:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442273002/1
5 years, 1 month ago (2015-11-13 22:24:13 UTC) #3
Mircea Trofin
On 2015/11/13 22:24:13, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 1 month ago (2015-11-13 22:33:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 22:48:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442273002/1
5 years, 1 month ago (2015-11-13 22:50:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 22:51:22 UTC) #9
Hezley Khez
On 2015/11/13 22:51:22, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 23:39:15 UTC) #10
Hezley Khez
Go go
5 years, 1 month ago (2015-11-13 23:40:47 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:22:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61a39335c6c315e26f8f8f35bf278266ffcecd6f
Cr-Commit-Position: refs/heads/master@{#31996}

Powered by Google App Engine
This is Rietveld 408576698