Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1442233002: Move stroke-dasharray property into CSSPropertyParser (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move stroke-dasharray property into CSSPropertyParser Move stroke-dasharray property handling from LegacyCSSPropertyParser into CSSPropertyParser. With this change the stroke-dasharray produces UserUnits CSSPrimitiveValues instead of Pixels. This caused regressions on interpolation tests, I added UserUnits to the unitTypeToLengthUnitType switch to fix this. BUG=499780 Committed: https://crrev.com/22ae97662a0aa4f9f697ec97d61b89c958b9cd31 Cr-Commit-Position: refs/heads/master@{#361069}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Address review comments #

Patch Set 4 : Rebase #

Patch Set 5 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 4 chunks +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 4 3 chunks +1 line, -32 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
rwlbuis
PTAL. Note that this currently fails, because of the UserUnits change. We now create CSSPrimitiveValue ...
5 years, 1 month ago (2015-11-18 03:45:36 UTC) #3
Timothy Loh
fs: Currently we have some restrictions on parsing CSS SVG properties (calcs and viewport units ...
5 years, 1 month ago (2015-11-19 02:16:48 UTC) #5
Timothy Loh
On 2015/11/18 03:45:36, rwlbuis wrote: > PTAL. > > Note that this currently fails, because ...
5 years, 1 month ago (2015-11-19 02:56:32 UTC) #6
rwlbuis
On 2015/11/19 02:56:32, Timothy Loh wrote: > Isn't this failing because we're now parsing with ...
5 years, 1 month ago (2015-11-19 03:16:45 UTC) #7
Timothy Loh
On 2015/11/19 03:16:45, rwlbuis wrote: > On 2015/11/19 02:56:32, Timothy Loh wrote: > > Isn't ...
5 years, 1 month ago (2015-11-19 03:33:32 UTC) #8
alancutter (OOO until 2018)
On 2015/11/19 at 03:33:32, timloh wrote: > On 2015/11/19 03:16:45, rwlbuis wrote: > > On ...
5 years, 1 month ago (2015-11-19 04:01:37 UTC) #9
fs
On 2015/11/19 at 02:16:48, timloh wrote: > fs: Currently we have some restrictions on parsing ...
5 years, 1 month ago (2015-11-19 11:23:23 UTC) #10
rwlbuis
On 2015/11/19 03:33:32, Timothy Loh wrote: > > You are right, sorry should have uploaded ...
5 years, 1 month ago (2015-11-19 22:51:14 UTC) #13
Timothy Loh
On 2015/11/19 22:51:14, rwlbuis wrote: > On 2015/11/19 03:33:32, Timothy Loh wrote: > > > ...
5 years, 1 month ago (2015-11-20 00:06:57 UTC) #14
Timothy Loh
On 2015/11/20 00:06:57, Timothy Loh wrote: > Can we update consumeLength to reject vw/vh/vmin/vmax and ...
5 years, 1 month ago (2015-11-20 00:07:14 UTC) #15
rwlbuis
On 2015/11/20 00:07:14, Timothy Loh wrote: > On 2015/11/20 00:06:57, Timothy Loh wrote: > > ...
5 years, 1 month ago (2015-11-21 02:12:48 UTC) #16
Timothy Loh
lgtm
5 years, 1 month ago (2015-11-23 00:22:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442233002/80001
5 years, 1 month ago (2015-11-23 03:18:02 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-23 04:39:29 UTC) #20
commit-bot: I haz the power
Failed to apply the patch.
5 years, 1 month ago (2015-11-23 04:39:48 UTC) #21
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 04:40:13 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/22ae97662a0aa4f9f697ec97d61b89c958b9cd31
Cr-Commit-Position: refs/heads/master@{#361069}

Powered by Google App Engine
This is Rietveld 408576698