Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1442203002: Fetch Mandoline components from Google Storage as needed. (Closed)

Created:
5 years, 1 month ago by msw
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch Mandoline components from Google Storage as needed. Proof-of-concept for fetching optional components. Return LocalFetcher redirect URLs for missing components. This uses NetworkFetcher to access Google Storage files: https://pantheon.corp.google.com/storage/browser/mandoline/ For example, delete pdf_viewer.mojo locally, and run: $ mandoline http://www.pdf995.com/samples/pdf.pdf --predictable-app-filenames TODO: Integrate with Mandoline's component updater? crbug.com/479169 TODO: Integrate with planned Omaha fetcher and updater work. TODO: Support fetching apps with resource files. TODO: Handle broken URLs. (unavailable component files, etc.) TODO: Avoid kPredictableAppFilenames switch? (need executable bit set) BUG=479169 TEST=Mandoline can fetch the pdf_viewer as needed. R=ben@chromium.org Committed: https://crrev.com/d629d1b58c5d54b9827d9fc753a53c0d60851261 Cr-Commit-Position: refs/heads/master@{#360735}

Patch Set 1 #

Patch Set 2 : Get the appropriate version and platform URL. #

Patch Set 3 : Get the relative app path; cleanup. #

Patch Set 4 : Cleanup #

Patch Set 5 : Sync and rebase. #

Patch Set 6 : Move //components/version_info to public_deps. #

Patch Set 7 : Fix gyp build; restore non-public GN dep. #

Patch Set 8 : Depend on more narrow version_info.gypi target to avoid ios gyp dep cycle. #

Patch Set 9 : Use the new 'latest' version folder on Google Storage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M mojo/fetcher/local_fetcher.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/fetcher/local_fetcher.cc View 1 2 3 4 5 6 7 8 5 chunks +33 lines, -1 line 0 comments Download
M mojo/package_manager/package_manager_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/package_manager/package_manager_impl.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (19 generated)
msw
Hey Ben, please take a look; thanks!
5 years, 1 month ago (2015-11-17 00:46:56 UTC) #5
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-17 00:51:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442203002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442203002/80001
5 years, 1 month ago (2015-11-17 00:53:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/67521)
5 years, 1 month ago (2015-11-17 00:59:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442203002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442203002/80001
5 years, 1 month ago (2015-11-17 02:37:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/124038) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-17 02:48:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442203002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442203002/100001
5 years, 1 month ago (2015-11-17 03:04:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/123554)
5 years, 1 month ago (2015-11-17 03:16:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442203002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442203002/120001
5 years, 1 month ago (2015-11-17 18:49:58 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/137457)
5 years, 1 month ago (2015-11-17 18:58:55 UTC) #24
msw
Hey Ben, I'm using a new 'latest' directory on our Google Storage bucket instead of ...
5 years, 1 month ago (2015-11-20 00:53:34 UTC) #26
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-20 00:54:27 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442203002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442203002/180001
5 years, 1 month ago (2015-11-20 00:56:24 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 03:02:40 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442203002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442203002/180001
5 years, 1 month ago (2015-11-20 03:06:39 UTC) #34
commit-bot: I haz the power
Committed patchset #9 (id:180001)
5 years, 1 month ago (2015-11-20 03:38:53 UTC) #35
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 03:39:39 UTC) #36
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/d629d1b58c5d54b9827d9fc753a53c0d60851261
Cr-Commit-Position: refs/heads/master@{#360735}

Powered by Google App Engine
This is Rietveld 408576698