Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1442143002: PPC: [turbofan] Better and more sane support for tail calls (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Better and more sane support for tail calls Port ff283f7ded84df5a5a77d088e37fd69cf6271a8c Original commit message: * Limit triggering of tail calls to explicit use of a new inline runtime function %_TailCall. %_TailCall works just like %_Call except for using tail-calling mechanics (currently only in TF). * Remove hack that recognized some specific usages of %_Call and converted them into tail calls. * Support tail calls for all calls where the number of callee stack parameters is less than or equal to the number of caller stack parameters. * Use the gap resolver to swizzle parameters and registers to tail calls. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4076 LOG=n Committed: https://crrev.com/cf2f6b80cb4bfe57fb10f509eb1077995aec9322 Cr-Commit-Position: refs/heads/master@{#31994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-13 19:44:00 UTC) #1
michael_dawson
On 2015/11/13 19:44:00, mtbrandyberry wrote: lgtm
5 years, 1 month ago (2015-11-13 19:51:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442143002/1
5 years, 1 month ago (2015-11-13 19:59:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 20:36:30 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf2f6b80cb4bfe57fb10f509eb1077995aec9322
Cr-Commit-Position: refs/heads/master@{#31994}

Powered by Google App Engine
This is Rietveld 408576698