Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1442103002: turn on libc++ for iOS (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
Sorry, didn't notice I broke this. Seems still broken in ways I don't quite understand.
5 years, 1 month ago (2015-11-13 19:00:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442103002/1
5 years, 1 month ago (2015-11-13 19:10:27 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-13 19:10:28 UTC) #5
stephana
On 2015/11/13 19:00:27, mtklein_C wrote: > Sorry, didn't notice I broke this. Seems still broken ...
5 years, 1 month ago (2015-11-13 19:10:40 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 19:22:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d28ada7fd6495923d8756f9738b8ca7044481b1d

Powered by Google App Engine
This is Rietveld 408576698