components/content_settings/core/test/content_settings_test_utils.cc - Issue 1442083002: Stop inheriting push notification permissions from regular to incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/test/content_settings_test_utils.cc

Issue 1442083002: Stop inheriting push notification permissions from regular to incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings/core/browser/content_settings_utils.cc ('K') | « components/content_settings/core/browser/host_content_settings_map.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/test/content_settings_test_utils.cc

diff --git a/components/content_settings/core/test/content_settings_test_utils.cc b/components/content_settings/core/test/content_settings_test_utils.cc

index 320a19eaa6dd75ed333cb66ff7ec45ed1286006a..2429d7bce1b1cc215ebc53844f12f713d76fc920 100644

--- a/components/content_settings/core/test/content_settings_test_utils.cc

+++ b/components/content_settings/core/test/content_settings_test_utils.cc

@@ -18,7 +18,8 @@ base::Value* GetContentSettingValue(const ProviderInterface* provider,

bool include_incognito) {

return GetContentSettingValueAndPatterns(provider, primary_url, secondary_url,

content_type, resource_identifier,

- include_incognito, NULL, NULL);

+ include_incognito, NULL,

+ NULL).release();

}

ContentSetting GetContentSetting(const ProviderInterface* provider,