components/content_settings/core/browser/content_settings_registry_unittest.cc - Issue 1442083002: Stop inheriting push notification permissions from regular to incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry_unittest.cc

Issue 1442083002: Stop inheriting push notification permissions from regular to incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings/core/browser/content_settings_registry.cc ('K') | « components/content_settings/core/browser/content_settings_registry.cc ('k') | components/content_settings/core/browser/content_settings_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry_unittest.cc

diff --git a/components/content_settings/core/browser/content_settings_registry_unittest.cc b/components/content_settings/core/browser/content_settings_registry_unittest.cc

index 153dc5bbc39726e366dca8368666950e6550a7e4..50d4b6c71a96503a4dd47a036cf6c70b09f9da00 100644

--- a/components/content_settings/core/browser/content_settings_registry_unittest.cc

+++ b/components/content_settings/core/browser/content_settings_registry_unittest.cc

@@ -44,6 +44,12 @@ TEST_F(ContentSettingsRegistryTest, Properties) {

expected_whitelist.push_back("chrome-devtools");

EXPECT_EQ(expected_whitelist, info->whitelisted_schemes());

+ // Check the other properties are populated correctly.

+ EXPECT_TRUE(info->IsSettingValid(CONTENT_SETTING_SESSION_ONLY));

+ EXPECT_FALSE(info->IsSettingValid(CONTENT_SETTING_ASK));

+ EXPECT_EQ(ContentSettingsInfo::INHERIT_IN_INCOGNITO,

+ info->incognito_behavior());

// Check the WebsiteSettingsInfo is populated correctly.

const WebsiteSettingsInfo* website_settings_info =

info->website_settings_info();