components/content_settings/core/browser/content_settings_registry.h - Issue 1442083002: Stop inheriting push notification permissions from regular to incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry.h

Issue 1442083002: Stop inheriting push notification permissions from regular to incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_provider_unittest.cc ('k') | components/content_settings/core/browser/content_settings_registry.cc » ('j') | components/content_settings/core/browser/content_settings_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry.h

diff --git a/components/content_settings/core/browser/content_settings_registry.h b/components/content_settings/core/browser/content_settings_registry.h

index f7e189075c489c428ca737368a8031d5d011814f..bfa532fae656a8456e0796acef4f7a3decf938ad 100644

--- a/components/content_settings/core/browser/content_settings_registry.h

+++ b/components/content_settings/core/browser/content_settings_registry.h

@@ -61,7 +61,8 @@ class ContentSettingsRegistry {

WebsiteSettingsInfo::SyncStatus sync_status,

const std::vector<std::string>& whitelisted_schemes,

const std::set<ContentSetting>& valid_settings,

- WebsiteSettingsInfo::ScopingType scoping_type);

+ WebsiteSettingsInfo::ScopingType scoping_type,

+ ContentSettingsInfo::IncognitoBehavior incognito_behavior);

Map content_settings_info_;

WebsiteSettingsRegistry* website_settings_registry_;