Stop inheriting push notification permissions from regular to incognito

components/content_settings/core/browser/host_content_settings_map.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/clock.h"
 #include "components/content_settings/core/browser/content_settings_default_provider.h"
 #include "components/content_settings/core/browser/content_settings_details.h"
 #include "components/content_settings/core/browser/content_settings_info.h"
 #include "components/content_settings/core/browser/content_settings_observable_provider.h"
 #include "components/content_settings/core/browser/content_settings_policy_provider.h"
 #include "components/content_settings/core/browser/content_settings_pref_provider.h"
 #include "components/content_settings/core/browser/content_settings_provider.h"
 #include "components/content_settings/core/browser/content_settings_registry.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
 #include "components/content_settings/core/browser/content_settings_utils.h"
+#include "components/content_settings/core/browser/website_settings_info.h"
 #include "components/content_settings/core/browser/website_settings_registry.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "components/content_settings/core/common/pref_names.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "net/base/net_errors.h"
 #include "net/base/static_cookie_policy.h"
 #include "url/gurl.h"
 
 namespace {
 
@@ skipping 103 matching lines @@
         rule.secondary_pattern == wildcard) {
       return content_settings::ValueToContentSetting(rule.value.get());
     }
   }
   return CONTENT_SETTING_DEFAULT;
 }
 
 ContentSetting HostContentSettingsMap::GetDefaultContentSetting(
     ContentSettingsType content_type,
     std::string* provider_id) const {
+  using content_settings::WebsiteSettingsInfo;

[msramek, 2015/11/27 16:30:04]

Nit: Is this allowed? I have seen it in tests and classes, but never inside
methods... In any case, there is just one callsite, so I would inline it
completely.

[raymes, 2015/11/30 00:28:46]

This was a suggestion from Michael. Either way is ok (it's really just style
preference), but I'd tend to side with msramek in this case..

[johnme, 2015/11/30 14:56:58]

Done.

[johnme, 2015/11/30 14:56:58]

Done.

+  using content_settings::WebsiteSettingsRegistry;
   UsedContentSettingsProviders();
 
+  const WebsiteSettingsRegistry* reg = WebsiteSettingsRegistry::GetInstance();
+  bool do_not_inherit_allow =
+      is_off_the_record_ &&
+      reg->Get(content_type)->incognito_behavior()
+          == WebsiteSettingsInfo::INHERIT_IN_INCOGNITO_EXCEPT_ALLOW;
+
   // Iterate through the list of providers and return the first non-NULL value
   // that matches |primary_url| and |secondary_url|.
   for (ConstProviderIterator provider = content_settings_providers_.begin();
        provider != content_settings_providers_.end();
        ++provider) {
     if (provider->first == PREF_PROVIDER)
       continue;
     ContentSetting default_setting =
         GetDefaultContentSettingFromProvider(content_type, provider->second);
+    if (do_not_inherit_allow && default_setting == CONTENT_SETTING_ALLOW)
+      default_setting = CONTENT_SETTING_ASK;

[msramek, 2015/11/27 16:30:04]

DCHECK ContentSettingsInfo::IsSettingValid(ASK)

Similarly in ContentSettingsRegistry, DCHECK(...) << "If
INHERIT_IN_INCOGNITO_EXCEPT_ALLOW is set, ASK must be listed as a valid
setting."

Alternatively, we could fall back to the default setting, but that can be ALLOW
as well, so that would be more complicated.

[raymes, 2015/11/30 00:28:46]

+1

[johnme, 2015/11/30 14:56:58]

Done.

[johnme, 2015/11/30 14:56:58]

Done.

     if (default_setting != CONTENT_SETTING_DEFAULT) {
       if (provider_id)
         *provider_id = kProviderNamesSourceMap[provider->first].provider_name;
       return default_setting;
     }
   }
 
   return CONTENT_SETTING_DEFAULT;
 }
 
@@ skipping 477 matching lines @@
     primary_pattern = &info->primary_pattern;
     secondary_pattern = &info->secondary_pattern;
   }
 
   // The list of |content_settings_providers_| is ordered according to their
   // precedence.
   for (ConstProviderIterator provider = content_settings_providers_.begin();
        provider != content_settings_providers_.end();
        ++provider) {
 
-    scoped_ptr<base::Value> value(
+    scoped_ptr<base::Value> value =
         content_settings::GetContentSettingValueAndPatterns(provider->second,
                                                             primary_url,
                                                             secondary_url,
                                                             content_type,
                                                             resource_identifier,
                                                             is_off_the_record_,
                                                             primary_pattern,
-                                                            secondary_pattern));
+                                                            secondary_pattern);
     if (value) {
       if (info)
         info->source = kProviderNamesSourceMap[provider->first].provider_source;
       return value.Pass();
     }
   }
 
   if (info) {
     info->source = content_settings::SETTING_SOURCE_NONE;
     info->primary_pattern = ContentSettingsPattern();
     info->secondary_pattern = ContentSettingsPattern();
   }
   return scoped_ptr<base::Value>();
 }