Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1442063002: Revert of Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js. (Closed)

Created:
5 years, 1 month ago by perkj_chrome
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js. (patchset #3 id:40001 of https://codereview.chromium.org/1438153002/ ) Reason for revert: Blamed for causing/surfacing a worse bug. Tentatively reverting. crbug/555575 Original issue's description: > Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js. > This fixes a bug where RTCPeerConnectionHandler::client_ is set to null when RTCPeerConnectionHandler.stop() is called. > RTCPeerConnectionHandler.stop() is a pretty bad name (override from blink::WebRTCPeerConnectionHandler) since it is triggered when JS or the browser process want to close a PeerConnection. > Since client_ was set to null, RTCPeerConnectionHandler::DestructAllHandlers did not delete RTCPeerConnectionHandler. > > BUG=542132 > > Committed: https://crrev.com/9596af111d9e82b0e27c9fab01fa688515623b1f > Cr-Commit-Position: refs/heads/master@{#359334} TBR=tommi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542132, 555575 Committed: https://crrev.com/3b988e383919f9d99cc66c3c691342cbc2c1c063 Cr-Commit-Position: refs/heads/master@{#359559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.h View 1 chunk +2 lines, -8 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 12 chunks +16 lines, -17 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
perkj_chrome
Created Revert of Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js.
5 years, 1 month ago (2015-11-13 16:19:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442063002/1
5 years, 1 month ago (2015-11-13 16:19:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 16:20:40 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 16:21:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b988e383919f9d99cc66c3c691342cbc2c1c063
Cr-Commit-Position: refs/heads/master@{#359559}

Powered by Google App Engine
This is Rietveld 408576698