Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: third_party/WebKit/Source/devtools/BUILD.gn

Issue 1442013004: Use GN response files for devtools .grd (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/BUILD.gn
diff --git a/third_party/WebKit/Source/devtools/BUILD.gn b/third_party/WebKit/Source/devtools/BUILD.gn
index 542f0843021eb77a3d7777dd348ebf8ac91f3ed6..c50d3202bcd61253c89841609a7b05c39fa47907 100644
--- a/third_party/WebKit/Source/devtools/BUILD.gn
+++ b/third_party/WebKit/Source/devtools/BUILD.gn
@@ -121,12 +121,8 @@ action("generate_devtools_grd") {
deps = [
":devtools_frontend_resources",
]
- static_files_list = "$target_gen_dir/devtools_static_grd_files.tmp"
inputs = gypi_values.devtools_image_files + all_devtools_files
inputs += gypi_values.devtools_compatibility_scripts
- inputs += [ static_files_list ]
-
- static_files = []
if (debug_devtools) {
# Debug: all files are picked as-is.
@@ -134,7 +130,15 @@ action("generate_devtools_grd") {
resources_out_dir + "inspector.html",
resources_out_dir + "toolbox.html",
]
- static_files += all_devtools_files + [ "front_end/Runtime.js" ]
+
+ # Use a response file since the static files can be too long for the
+ # command line. The args here will be added to the command line.
+ static_files = all_devtools_files + [ "front_end/Runtime.js" ]
+ response_file_contents = rebase_path(static_files, root_build_dir)
+ static_files_args = [
+ "--static_files_args",
+ "{{response_file_name}}",
+ ]
} else {
# Release: pick compiled non-remote files and lazy-loaded CSS.
generated_files = [
@@ -169,9 +173,9 @@ action("generate_devtools_grd") {
resources_out_dir + "ui_lazy_module.js",
resources_out_dir + "devtools_extension_api.js",
]
+ static_files_args = [] # Nothing needed for this
}
- write_file(static_files_list, rebase_path(static_files, root_build_dir))
images_path = "front_end/Images"
inputs += generated_files
@@ -190,11 +194,8 @@ action("generate_devtools_grd") {
rebase_path(generated_files, root_build_dir) +
rebase_path(generated_files, root_build_dir) +
rebase_path(gypi_values.devtools_compatibility_scripts, root_build_dir) +
- [
- "--static_files_list",
- rebase_path(static_files_list, root_build_dir),
- "--relative_path_dirs",
- ] + rebase_path(relative_path_dirs, root_build_dir) +
+ static_files_args + [ "--relative_path_dirs" ] +
+ rebase_path(relative_path_dirs, root_build_dir) +
[
"--images",
rebase_path(images_path, root_build_dir),
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698