third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 1441973003: Use recomputed interest rect only if it changed enough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 1441973003: Use recomputed interest rect only if it changed enough (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix release builds Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/VisualViewport.h ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index eb0b00295e8bf348b8b6580eba9a624c47ad10b9..e213c08951234eac80857c23853fe38bf11e9541 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -579,7 +579,12 @@ GraphicsLayer* VisualViewport::layerForVerticalScrollbar() const

return m_overlayScrollbarVertical.get();

}

-void VisualViewport::paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect* inClip) const

+IntRect VisualViewport::computeInterestRect(const GraphicsLayer*, const IntRect&) const

+ return IntRect();

+void VisualViewport::paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect&) const

{

}

@@ -719,7 +724,7 @@ bool VisualViewport::shouldDisableDesktopWorkarounds() const

|| (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);

}

-String VisualViewport::debugName(const GraphicsLayer* graphicsLayer)

+String VisualViewport::debugName(const GraphicsLayer* graphicsLayer) const

{

String name;

if (graphicsLayer == m_innerViewportContainerLayer.get()) {