Issue 144193005: ES6: Implement Object.setPrototypeOf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144193005: ES6: Implement Object.setPrototypeOf (Closed)

Created:
6 years, 11 months ago by arv (Not doing code reviews)

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Lomov (no reviews), rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

ES6: Implement Object.setPrototypeOf This reverts commit bdc89ae76c15f3ef2626f8849744500248aec3ba. This is a revert of the revert with test/webkit updated as needed. Original CL Description: http://people.mozilla.org/~jorendorff/es6-draft.html#sec-object.setprototypeof This just exposes the internal %SetPrototype and adds all the required type checks as specified. BUG=v8:2675 LOG=Y R=dslomov@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18739

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+235 lines, -85 lines)			Patch
M	src/macros.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/messages.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/string.js	View	14 chunks	+40 lines, -80 lines	0 comments	Download
M	src/v8natives.js	View	2 chunks	+16 lines, -0 lines	0 comments	Download
A	test/mjsunit/set-prototype-of.js	View	1 chunk	+170 lines, -0 lines	0 comments	Download
M	test/webkit/Object-create-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/webkit/fast/js/Object-getOwnPropertyNames.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Dmitry Lomov (no reviews)

I'll land, also will check whether this breaks any layout tests in webkit.

6 years, 11 months ago (2014-01-22 08:37:05 UTC) #3

Dmitry Lomov (no reviews)

6 years, 11 months ago (2014-01-22 12:16:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18739 (presubmit successful).