Issue 14419: Porting in browser/webdata and template_url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14419: Porting in browser/webdata and template_url. (Closed)

Created:
12 years ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
petersont, Mark Mentovai, sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Porting in browser/webdata and template_url. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7052

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -202 lines)			Patch
M	chrome/browser/browser.scons	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser.vcproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/template_url.cc	View	1	3 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/template_url_model.cc	View	1	4 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/template_url_model_unittest.cc	View	1	8 chunks	+10 lines, -12 lines	0 comments	Download
M	chrome/browser/template_url_parser_unittest.cc	View	1	7 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.h	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/webdata/web_database.h	View	1	4 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View	1	7 chunks	+4 lines, -101 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View	1	28 chunks	+46 lines, -50 lines	0 comments	Download
A	chrome/browser/webdata/web_database_win.cc	View		1 chunk	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. It seems like we might be able to keep some strings in narrow format ...

12 years ago (2008-12-15 15:37:25 UTC) #2

Paweł Hajdan Jr.

12 years ago (2008-12-15 16:23:38 UTC) #3

On 2008/12/15 15:37:25, Mark Mentovai wrote:
> LGTM.  It seems like we might be able to keep some strings in narrow format
> longer instead of just calling WideToUTF8 at the point of GURL conversion, but
I
> haven't thought looked too closely into this.

Sure. I recently did similar refactoring in TemplateURL, and it'll be probably
more of them.

> http://codereview.chromium.org/14419/diff/1/5
> File chrome/browser/webdata/web_database.h (right):
> 
> http://codereview.chromium.org/14419/diff/1/5#newcode84
> Line 84: #if defined(OS_WIN)
> Can we group the IE7 functions together to reduce #ifdefs?

Done.

Expand Messages | Collapse Messages