content/common/media/media_session_messages_android.h - Issue 1441883003: Hook up RendererMediaSessionManager with browser side

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/media/media_session_messages_android.h

Issue 1441883003: Hook up RendererMediaSessionManager with browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comment from philipj: ActiveDOMObject Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/media/android/browser_media_session_manager.h ('K') | « content/common/content_message_generator.h ('k') | content/content_browser.gypi » ('j') | content/renderer/media/android/renderer_media_session_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // IPC messages for the Media Session API.

	6 // Multiply-included message file, hence no include guard.

	7

	8 #include "base/basictypes.h"

	9 #include "content/common/android/gin_java_bridge_errors.h"

	10 #include "content/common/content_export.h"

	11 #include "ipc/ipc_message_macros.h"

	12

	13 #undef IPC_MESSAGE_EXPORT

	14 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

	15 #define IPC_MESSAGE_START MediaSessionMsgStart

	16

	17 // Messages for notifying the render process of media session status -------

	18

	19 IPC_MESSAGE_ROUTED3(MediaSessionMsg_DidActivate,

	20 int /* session_id */,

	21 int /* request_id */,

	22 bool /* success */)
	mlamouri (slow - plz ping) 2015/12/07 18:14:52 Just note that we could make \|request_id\| map to t Just note that we could make \|request_id\| map to the right \|session_id\|. I think what you have here is fine given that we don't reuse \|session_id\| in the same process. davve 2015/12/08 10:21:23 Acknowledged. Show quoted text On 2015/12/07 18:14:52, Mounir Lamouri wrote: > Just note that we could make \|request_id\| map to the right \|session_id\|. I think > what you have here is fine given that we don't reuse \|session_id\| in the same > process. Acknowledged.
	23

	24 IPC_MESSAGE_ROUTED2(MediaSessionMsg_DidDeactivate,

	25 int /* session_id */,

	26 int /* request_id */)

	27

	28 // Messages for controlling the media session in browser process ----------

	29

	30 IPC_MESSAGE_ROUTED2(MediaSessionHostMsg_Activate,

	31 int /* session_id */,

	32 int /* request_id */)

	33

	34 IPC_MESSAGE_ROUTED2(MediaSessionHostMsg_Deactivate,

	35 int /* session_id */,

	36 int /* request_id */)

OLD	NEW