Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: mojo/edk/test/multiprocess_test_helper.cc

Issue 1441853003: Make the new Mojo EDK work on XP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/test/multiprocess_test_helper.cc
diff --git a/mojo/edk/test/multiprocess_test_helper.cc b/mojo/edk/test/multiprocess_test_helper.cc
index 10645f9311e1b3dd4825b51ebc8447df60af55ba..b07866ef445e7617f22cfa9a3dca02fae03f50bf 100644
--- a/mojo/edk/test/multiprocess_test_helper.cc
+++ b/mojo/edk/test/multiprocess_test_helper.cc
@@ -11,6 +11,10 @@
#include "build/build_config.h"
#include "mojo/edk/embedder/platform_channel_pair.h"
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
namespace mojo {
namespace edk {
namespace test {
@@ -59,7 +63,10 @@ void MultiprocessTestHelper::StartChildWithExtraSwitch(
options.fds_to_remap = &handle_passing_info;
#elif defined(OS_WIN)
options.start_hidden = true;
- options.handles_to_inherit = &handle_passing_info;
+ if (base::win::GetVersion() >= base::win::VERSION_VISTA)
+ options.handles_to_inherit = &handle_passing_info;
+ else
+ options.inherit_handles = true;
#else
#error "Not supported yet."
#endif

Powered by Google App Engine
This is Rietveld 408576698