Convert to gtest-style filtering in instrumentation tests.

build/android/pylib/instrumentation/test_jar.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Helper class for instrumenation test jar."""
 
 import collections
 import logging
 import os
 import pickle
 import re
+import sys
 
 from pylib import cmd_helper
 from pylib import constants
 
+sys.path.insert(0,
+                os.path.join(constants.DIR_SOURCE_ROOT,
+                             'build', 'util', 'lib', 'common'))
+
+import unittest_util
 
 # If you change the cached output of proguard, increment this number
 PICKLE_FORMAT_VERSION = 1
 
 
 class TestJar(object):
   _ANNOTATIONS = frozenset(
       ['Smoke', 'SmallTest', 'MediumTest', 'LargeTest', 'EnormousTest',
        'FlakyTest', 'DisabledTest', 'Manual', 'PerfTest', 'HostDrivenTest'])
   _DEFAULT_ANNOTATION = 'SmallTest'
@@ skipping 174 matching lines @@
       if exclude_annotation_list:
         excluded_tests = self.GetAnnotatedTests(exclude_annotation_list)
         available_tests = list(set(available_tests) - set(excluded_tests))
     else:
       available_tests = [m for m in self.GetTestMethods()
                          if not self.IsHostDrivenTest(m)]
 
     tests = []
     if test_filter:
       # |available_tests| are in adb instrument format: package.path.class#test.
-      filter_without_hash = test_filter.replace('#', '.')
-      tests = [t for t in available_tests
-               if filter_without_hash in t.replace('#', '.')]
+
+      # Maps a 'class.test' name to each 'package.path.class#test' name.
+      sanitized_test_names = {
+          t.split('.')[-1].replace('#', '.') : t for t in available_tests}

[frankf, 2014/01/22 22:14:11]

dictionary comprehension is only python 2.7+ right?

+      # Filters 'class.test' names and populates |tests| with the corresponding
+      # 'package.path.class#test' names.
+      tests = [sanitized_test_names[t] for t in
+          unittest_util.FilterTestNames(
+              sanitized_test_names.keys(),
+              test_filter.replace('#', '.'))]

[frankf, 2014/01/22 22:14:11]

this is pretty unreadable, can you tweak the white space?

     else:
       tests = available_tests
 
     return tests
 
   @staticmethod
   def IsHostDrivenTest(test):
     return 'pythonDrivenTests' in test