Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1441773002: SkAtomic: always use std::atomic (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkAtomic: always use std::atomic We were doing it on Windows, now do it everywhere. This just changes the backend. We could think about another step to actually replacing all our sk_atomic_... with std atomic stuff. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot TBR=reed@google.com Only deleting from include/... Committed: https://skia.googlesource.com/skia/+/23267db67824a92f045649f571ae1ceaf2cc2b28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -221 lines) Patch
M gyp/ports.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
D include/ports/SkAtomics_atomic.h View 1 chunk +0 lines, -59 lines 0 comments Download
D include/ports/SkAtomics_std.h View 1 chunk +0 lines, -71 lines 0 comments Download
D include/ports/SkAtomics_sync.h View 1 chunk +0 lines, -73 lines 0 comments Download
M include/private/SkAtomics.h View 2 chunks +62 lines, -9 lines 0 comments Download
M tools/BUILD.public.expected View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441773002/1
5 years, 1 month ago (2015-11-12 18:41:39 UTC) #3
mtklein_C
5 years, 1 month ago (2015-11-12 18:53:45 UTC) #5
bungeman-skia
Why not? lgtm
5 years, 1 month ago (2015-11-12 19:05:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441773002/1
5 years, 1 month ago (2015-11-12 19:07:10 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:07:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23267db67824a92f045649f571ae1ceaf2cc2b28

Powered by Google App Engine
This is Rietveld 408576698