Issue 1441763002: Static warning fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1441763002: Static warning fixes. (Closed)

Created:
5 years, 1 month ago by pquitslund

Modified:
5 years, 1 month ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Static warning fixes. The good news is that I reproduced a server issue; the bad news is I landed a change with unnoticed static warnings! :/ (This fixes them.) BUG= Dup of: https://codereview.chromium.org/1437133005/ Committed: https://github.com/dart-lang/sdk/commit/60e04f734aa42c3e66613ef9f42da720ee50b728

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analyzer/lib/src/task/options.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

pquitslund

5 years, 1 month ago (2015-11-12 18:22:26 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
60e04f734aa42c3e66613ef9f42da720ee50b728 (presubmit successful).