Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441753002: Replace SkFunction with std::function (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace SkFunction with std::function TBR=reed@google.com No public API changes. Committed: https://skia.googlesource.com/skia/+/64593525debc63339e1bf9ddb8a0e998f7d976a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -162 lines) Patch
M dm/DMSrcSink.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/private/SkFunction.h View 1 chunk +0 lines, -76 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.h View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/CPlusPlusEleven.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D tests/FunctionTest.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M tools/BUILD.public.expected View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441753002/1
5 years, 1 month ago (2015-11-12 18:16:50 UTC) #2
mtklein_C
5 years, 1 month ago (2015-11-12 18:21:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 18:28:11 UTC) #6
bungeman-skia
lgtm
5 years, 1 month ago (2015-11-12 18:32:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441753002/1
5 years, 1 month ago (2015-11-12 18:33:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3854)
5 years, 1 month ago (2015-11-12 18:34:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441753002/1
5 years, 1 month ago (2015-11-12 18:40:31 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 18:41:09 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/64593525debc63339e1bf9ddb8a0e998f7d976a3

Powered by Google App Engine
This is Rietveld 408576698