Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1441743004: Making bots greener (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra, Cutch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
srdjan
TBR
5 years, 1 month ago (2015-11-13 17:39:52 UTC) #2
srdjan
Committed patchset #1 (id:1) manually as 6f734612022facc26b67e67761c154563e4f7916 (presubmit successful).
5 years, 1 month ago (2015-11-13 17:40:23 UTC) #3
Cutch
On 2015/11/13 17:39:52, srdjan wrote: > TBR DBC- Timeout only for Windows.
5 years, 1 month ago (2015-11-13 17:40:37 UTC) #4
srdjan
On 2015/11/13 17:40:37, Cutch wrote: > On 2015/11/13 17:39:52, srdjan wrote: > > TBR > ...
5 years, 1 month ago (2015-11-13 17:44:19 UTC) #5
rmacnak
lgtm
5 years, 1 month ago (2015-11-13 18:00:39 UTC) #6
Florian Schneider
5 years, 1 month ago (2015-11-16 09:09:07 UTC) #8
Message was sent while issue was closed.
Issue number?

There seem to be other frequent timeouts on Windows as well: Some are expected
to crash, e.g.

vm/cc/VerifyExplicit_Crash

others are not:

standalone/full_coverage_test
standalone/io/process_sync_test

Are these the same issue - i.e. a timeout instead of a crash?

Powered by Google App Engine
This is Rietveld 408576698