Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2505)

Unified Diff: Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp

Issue 144173002: Hard codes ScrollbarThemeGtkOrAura::scrollbarThickness to 15 in layout test mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: early out Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp
diff --git a/Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp b/Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp
index 05213464211107014b8fc21fb2f1e944f995a58b..65b076f9e5133c85af4c532de8ab935c23420188 100644
--- a/Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp
+++ b/Source/platform/scroll/ScrollbarThemeGtkOrAura.cpp
@@ -62,6 +62,9 @@ ScrollbarTheme* ScrollbarTheme::nativeTheme()
int ScrollbarThemeGtkOrAura::scrollbarThickness(ScrollbarControlSize controlSize)
{
// Horiz and Vert scrollbars are the same thickness.
+ // In unit tests we don't have the mock theme engine (because of layering violations), so we hard code the size (see bug 327470).
+ if (useMockTheme())
+ return 15;
IntSize scrollbarSize = blink::Platform::current()->themeEngine()->getSize(blink::WebThemeEngine::PartScrollbarVerticalTrack);
return scrollbarSize.width();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698