chrome/android/java/res/layout/web_notification_button.xml - Issue 1441723002: Notification custom layouts: paint the button icon for Material.

Side by Side Diff: chrome/android/java/res/layout/web_notification_button.xml

Issue 1441723002: Notification custom layouts: paint the button icon for Material. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Documentation tweaks. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <Button xmlns:android="http://schemas.android.com/apk/res/android"	6 <!--

7 android:drawablePadding="0dp"	7 Overlays a Button on top of an ImageView. Via a RemoteViews, the only way to set a Bitmap is on

8 android:ellipsize="end"	8 an ImageView. We have a Bitmap because it is the format that can be painted to match the theme,

9 android:gravity="start\|center_vertical"	9 and it is the format we get when loading an image from the network.

10 android:id="@+id/button"	10 -->

	11 <FrameLayout
	newt (away) 2015/11/16 17:50:08 Do these views need to overlap? If not, can't you Do these views need to overlap? If not, can't you just use a horizontal LinearLayout? If so, why do they need to overlap? Should the image be clickable? Could you use an ImageButton here? Or could you use compound drawables (see RemoteViews.setTextViewCompoundDrawables())? If you want both the image and the text to be clickable as part of the same button, then compound drawables are your friend. Michael van Ouwerkerk 2015/11/17 12:00:23 I would have preferred to use RemoteViews#setTextV Show quoted text On 2015/11/16 17:50:08, newt wrote: > Do these views need to overlap? If not, can't you just use a horizontal > LinearLayout? If so, why do they need to overlap? Should the image be clickable? > Could you use an ImageButton here? Or could you use compound drawables (see > RemoteViews.setTextViewCompoundDrawables())? > > If you want both the image and the text to be clickable as part of the same > button, then compound drawables are your friend. I would have preferred to use RemoteViews#setTextViewCompoundDrawablesRelativeColorFilter(int viewId, int index, int color, PorterDuff.Mode mode) but that method is hidden. It's what the core framework uses for this situation. There is setTextViewCompoundDrawables(int viewId, int left, int top, int right, int bottom) but that does not apply a color filter. Then there is setTextViewCompoundDrawables(int viewId, Icon left, Icon top, Icon right, Icon bottom) but it is hidden and also uses Icon which is from API level 23 only. The _only_ way to apply a PorterDuffColorFilter (or an equivalent) to an image and somehow get that image into a RemoteViews, compatible from at least API level 16, is to acquire a Bitmap, paint that, and pass it to the RemoteViews. Then, the _only_ useful way to set that Bitmap is on an ImageView using setImageViewBitmap. So that's why this is a Button layered on top of an ImageView. It is intentional, though a bit more work than anticipated. From a UX perspective, the difference is undetectable: a11y is the same, look and feel are the same, RTL is the same. As the Button overlays the ImageView, it feels as if the image is clickable, as intended, it feels like it is part of the button. newt (away) 2015/11/17 20:04:40 Yowsers. Thanks for the run down. I wasn't thinkin Show quoted text On 2015/11/17 12:00:23, Michael van Ouwerkerk wrote: > On 2015/11/16 17:50:08, newt wrote: > > Do these views need to overlap? If not, can't you just use a horizontal > > LinearLayout? If so, why do they need to overlap? Should the image be > clickable? > > Could you use an ImageButton here? Or could you use compound drawables (see > > RemoteViews.setTextViewCompoundDrawables())? > > > > If you want both the image and the text to be clickable as part of the same > > button, then compound drawables are your friend. > > I would have preferred to use > RemoteViews#setTextViewCompoundDrawablesRelativeColorFilter(int viewId, int > index, int color, PorterDuff.Mode mode) but that method is hidden. It's what the > core framework uses for this situation. > > There is setTextViewCompoundDrawables(int viewId, int left, int top, int right, > int bottom) but that does not apply a color filter. > > Then there is setTextViewCompoundDrawables(int viewId, Icon left, Icon top, Icon > right, Icon bottom) but it is hidden and also uses Icon which is from API level > 23 only. > > The _only_ way to apply a PorterDuffColorFilter (or an equivalent) to an image > and somehow get that image into a RemoteViews, compatible from at least API > level 16, is to acquire a Bitmap, paint that, and pass it to the RemoteViews. > > Then, the _only_ useful way to set that Bitmap is on an ImageView using > setImageViewBitmap. > > So that's why this is a Button layered on top of an ImageView. It is > intentional, though a bit more work than anticipated. From a UX perspective, the > difference is undetectable: a11y is the same, look and feel are the same, RTL is > the same. As the Button overlays the ImageView, it feels as if the image is > clickable, as intended, it feels like it is part of the button. Yowsers. Thanks for the run down. I wasn't thinking about the fact that you need to combine a compound drawable with a color filter. Given that, I think the current solution is reasonable. It would probably be good to elaborate a bit on why you can't use compound drawables in the comment above. Michael van Ouwerkerk 2015/11/18 14:08:40 Done. I've added some more docs here. Show quoted text On 2015/11/17 20:04:40, newt wrote: > On 2015/11/17 12:00:23, Michael van Ouwerkerk wrote: > > On 2015/11/16 17:50:08, newt wrote: > > > Do these views need to overlap? If not, can't you just use a horizontal > > > LinearLayout? If so, why do they need to overlap? Should the image be > > clickable? > > > Could you use an ImageButton here? Or could you use compound drawables (see > > > RemoteViews.setTextViewCompoundDrawables())? > > > > > > If you want both the image and the text to be clickable as part of the same > > > button, then compound drawables are your friend. > > > > I would have preferred to use > > RemoteViews#setTextViewCompoundDrawablesRelativeColorFilter(int viewId, int > > index, int color, PorterDuff.Mode mode) but that method is hidden. It's what > the > > core framework uses for this situation. > > > > There is setTextViewCompoundDrawables(int viewId, int left, int top, int > right, > > int bottom) but that does not apply a color filter. > > > > Then there is setTextViewCompoundDrawables(int viewId, Icon left, Icon top, > Icon > > right, Icon bottom) but it is hidden and also uses Icon which is from API > level > > 23 only. > > > > The _only_ way to apply a PorterDuffColorFilter (or an equivalent) to an image > > and somehow get that image into a RemoteViews, compatible from at least API > > level 16, is to acquire a Bitmap, paint that, and pass it to the RemoteViews. > > > > Then, the _only_ useful way to set that Bitmap is on an ImageView using > > setImageViewBitmap. > > > > So that's why this is a Button layered on top of an ImageView. It is > > intentional, though a bit more work than anticipated. From a UX perspective, > the > > difference is undetectable: a11y is the same, look and feel are the same, RTL > is > > the same. As the Button overlays the ImageView, it feels as if the image is > > clickable, as intended, it feels like it is part of the button. > > Yowsers. Thanks for the run down. I wasn't thinking about the fact that you need > to combine a compound drawable with a color filter. > > Given that, I think the current solution is reasonable. It would probably be > good to elaborate a bit on why you can't use compound drawables in the comment > above. Done. I've added some more docs here.
	12 xmlns:android="http://schemas.android.com/apk/res/android"

	13 xmlns:tools="http://schemas.android.com/tools"

	14 tools:ignore="MergeRootFrame"

	15 android:layout_width="0dp"

11 android:layout_height="48dp"	16 android:layout_height="48dp"

12 android:layout_weight="1"	17 android:layout_weight="1">

13 android:layout_width="0dp"	18

14 android:paddingStart="8dp"	19 <ImageView

15 android:singleLine="true"	20 android:id="@+id/button_icon"

16 android:textSize="13sp"	21 android:layout_width="wrap_content"

17 style="@style/WebNotificationButton"/>	22 android:layout_height="match_parent"

	23 android:layout_marginStart="8dp"

	24 android:layout_gravity="start\|center_vertical"

	25 android:maxWidth="48dp"

	26 android:contentDescription="@null"

	27 android:scaleType="centerInside"/>

	28

	29 <Button
	newt (away) 2015/11/17 20:04:40 Will there always be button text, or will we have Will there always be button text, or will we have notifications where there's just an image but no text? Michael van Ouwerkerk 2015/11/18 14:08:40 Action (button) titles are required at the JavaScr Show quoted text On 2015/11/17 20:04:40, newt wrote: > Will there always be button text, or will we have notifications where there's > just an image but no text? Action (button) titles are required at the JavaScript API level.
	30 android:id="@+id/button"

	31 android:layout_width="match_parent"

	32 android:layout_height="match_parent"

	33 android:drawablePadding="0dp"
	newt (away) 2015/11/17 20:04:40 not needed? (since there are no compound drawables not needed? (since there are no compound drawables) Michael van Ouwerkerk 2015/11/18 14:08:40 Done. Show quoted text On 2015/11/17 20:04:40, newt wrote: > not needed? (since there are no compound drawables) Done.
	34 android:ellipsize="end"

	35 android:gravity="start\|center_vertical"

	36 android:paddingStart="8dp"

	37 android:singleLine="true"

	38 android:textSize="13sp"

	39 style="@style/WebNotificationButton"/>

	40

	41 </FrameLayout>

OLD	NEW