Added support for private projects.

Added support for private projects.

_gen_* functions are defined in projects.py. This file now looks for
../commit-queue-internal/projects_internal.py for more _gen_* functions.

BUG=336455
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247456

[pgervais, 2014-01-21 17:43:50]

Here is a simple way to add private (or custom) queues to the commit queue
codebase.

[Paweł Hajdan Jr., 2014-01-21 18:19:05]

Looks good, just minor comments. Please make sure local presubmit tests pass
(this is mostly informational, CQ won't commit if they don't pass anyway).

https://codereview.chromium.org/144163002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/144163002/diff/1/projects.py#newcode42
projects.py:42: import projects_internal   # pylint: disable=F0401
nit: Just 2 spaces between code and comment instead of 3 please.

https://codereview.chromium.org/144163002/diff/1/projects.py#newcode772
projects.py:772: if projects_internal is not None:
nit: Why not just projects_internal? (remove the "is not None" part)

https://codereview.chromium.org/144163002/diff/1/projects.py#newcode776
projects.py:776: logging.warn('public project function %s overriden by private
one'
I'd like to make this stronger than just a warning. It's too easy to ignore and
create a mess. Why not raise an exception instead?

[pgervais, 2014-01-21 18:57:24]

Replied to one comment, I'll fix the other issues soon.

https://codereview.chromium.org/144163002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/144163002/diff/1/projects.py#newcode776
projects.py:776: logging.warn('public project function %s overriden by private
one'
On 2014/01/21 18:19:06, Paweł Hajdan Jr. wrote:
> I'd like to make this stronger than just a warning. It's too easy to ignore
and
> create a mess. Why not raise an exception instead?

Because "internal" projects can also be used for testing and development, and
overriding an existing project this way could be useful. However, I will not
stick to it if you find it useless.

[Paweł Hajdan Jr., 2014-01-21 22:29:44]

https://codereview.chromium.org/144163002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/144163002/diff/1/projects.py#newcode776
projects.py:776: logging.warn('public project function %s overriden by private
one'
On 2014/01/21 18:57:24, pgervais wrote:
> On 2014/01/21 18:19:06, Paweł Hajdan Jr. wrote:
> > I'd like to make this stronger than just a warning. It's too easy to ignore
> and
> > create a mess. Why not raise an exception instead?
> 
> Because "internal" projects can also be used for testing and development, and
> overriding an existing project this way could be useful. However, I will not
> stick to it if you find it useless.

I find it dangerous enough to really avoid supporting it. Let's raise an
exception unless there is a really good reason for an actually existing use
case.

[pgervais, 2014-01-23 23:26:21]

Fixed the issues you raised, Paweł.

[Paweł Hajdan Jr., 2014-01-27 18:23:16]

LGTM with a tiny style comment

https://codereview.chromium.org/144163002/diff/80001/projects.py
File projects.py (right):

https://codereview.chromium.org/144163002/diff/80001/projects.py#newcode777
projects.py:777: 'public project function %s overriden by private one'
nit: Let's indent +4 instead of +2 here and line below.

[commit-bot: I haz the power, 2014-01-28 16:35:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pgervais@chromium.org/144163002/130002

[commit-bot: I haz the power, 2014-01-28 16:36:19]

Change committed as 247456