Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2959)

Unified Diff: cc/raster/task_graph_runner_unittest.cc

Issue 1441613002: cc: Remove ScopedPtrDeque. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/raster/one_copy_tile_task_worker_pool.cc ('k') | cc/resources/resource_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/raster/task_graph_runner_unittest.cc
diff --git a/cc/raster/task_graph_runner_unittest.cc b/cc/raster/task_graph_runner_unittest.cc
index eb9b6d954b7249620d715ea496ede01d3fac900f..31144e729534d1a68f9cbffc236c66881f6e78c5 100644
--- a/cc/raster/task_graph_runner_unittest.cc
+++ b/cc/raster/task_graph_runner_unittest.cc
@@ -4,12 +4,13 @@
#include "cc/raster/task_graph_runner.h"
+#include <deque>
#include <vector>
#include "base/bind.h"
#include "base/synchronization/lock.h"
#include "base/threading/simple_thread.h"
-#include "cc/base/scoped_ptr_deque.h"
+#include "cc/base/container_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cc {
@@ -181,8 +182,8 @@ class TaskGraphRunnerTest : public TaskGraphRunnerTestBase,
}
void TearDown() override {
task_graph_runner_->Shutdown();
- while (workers_.size()) {
- scoped_ptr<base::DelegateSimpleThread> worker = workers_.take_front();
+ while (!workers_.empty()) {
+ scoped_ptr<base::DelegateSimpleThread> worker = PopFront(&workers_);
worker->Join();
}
}
@@ -191,7 +192,7 @@ class TaskGraphRunnerTest : public TaskGraphRunnerTestBase,
// Overridden from base::DelegateSimpleThread::Delegate:
void Run() override { task_graph_runner_->Run(); }
- ScopedPtrDeque<base::DelegateSimpleThread> workers_;
+ std::deque<scoped_ptr<base::DelegateSimpleThread>> workers_;
};
TEST_P(TaskGraphRunnerTest, Basic) {
« no previous file with comments | « cc/raster/one_copy_tile_task_worker_pool.cc ('k') | cc/resources/resource_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698